# Re: \[PATCH 11/14\] fbdev/pxafb: Unexport symbol

- From: Helge Deller \<deller@gmx.de\>
- Date: 2025-06-10 22:48:27 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2025/06/8854373
- Thread: https://ratatoskr.run/linux-fbdev/2025/06/8854358/t.md

```text
On 6/10/25 12:56, Thomas Zimmermann wrote:
> Fix the compile-time warning
>
>    drivers/video/fbdev/pxafb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> The affected symbol is not used outside of its module.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/video/fbdev/pxafb.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index ee6da5084242..f15310bf94cf 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -1058,7 +1058,6 @@ unsigned long pxafb_get_hsync_time(struct device *dev)
>   
>   	return fbi->hsync_time;
>   }
> -EXPORT_SYMBOL(pxafb_get_hsync_time);

True, the function does not seem to be used anywhere (at least not any longer).
A comment in the file says:
 * Some touchscreens need hsync information from the video driver to
 * function correctly.
Not sure if such touchscreen drivers still exist, but they don't seem
to be in-kernel.

So, if we clean up here, maybe you should then simply remove the whole
function and the reference to it in the header file too?

Helge
```