[FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

2 messages, 2 authors, 2025-05-07 · open the first message on its own page

[FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.

From: Rujra Bhatt <hidden>
Date: 2025-05-07 14:31:30

instead of "parm" structure variable, used "param" to ease the readability.

Signed-off-by: Rujra Bhatt <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 3b25892af713..8f2708632c88 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
 	}
 }
 
-int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
+int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
 {
 	struct pll_value pll;
 
 	pll.input_freq = DEFAULT_INPUT_CLOCK;
 	pll.clock_type = clock;
 
-	sm750_calc_pll_value(parm->pixel_clock, &pll);
+	sm750_calc_pll_value(param->pixel_clock, &pll);
 	if (sm750_get_chip_type() == SM750LE) {
 		/* set graphic mode via IO method */
 		outb_p(0x88, 0x3d4);
 		outb_p(0x06, 0x3d5);
 	}
-	program_mode_registers(parm, &pll);
+	program_mode_registers(param, &pll);
 	return 0;
 }
-- 
2.43.0

Re: [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2025-05-07 14:37:09

On Wed, May 07, 2025 at 08:01:26PM +0530, Rujra Bhatt wrote:
quoted hunk
instead of "parm" structure variable, used "param" to ease the readability.

Signed-off-by: Rujra Bhatt <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 3b25892af713..8f2708632c88 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
 	}
 }
 
-int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
+int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
 {
 	struct pll_value pll;
 
 	pll.input_freq = DEFAULT_INPUT_CLOCK;
 	pll.clock_type = clock;
 
-	sm750_calc_pll_value(parm->pixel_clock, &pll);
+	sm750_calc_pll_value(param->pixel_clock, &pll);
 	if (sm750_get_chip_type() == SM750LE) {
 		/* set graphic mode via IO method */
 		outb_p(0x88, 0x3d4);
 		outb_p(0x06, 0x3d5);
 	}
-	program_mode_registers(parm, &pll);
+	program_mode_registers(param, &pll);
This change is really not needed at all, sorry.  Adding one character
doesn't make it easier to understand in my opinion.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help