# Re: \[PATCH\] staging: sm750fb: Replace architecture-specific defines with CONFIG\_X86

- From: Greg KH \<gregkh@linuxfoundation.org\>
- Date: 2025-03-20 14:14:08 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2025/03/2979870
- Thread: https://ratatoskr.run/linux-fbdev/2025/02/2939345/t.md

```text
On Sun, Feb 23, 2025 at 01:02:42AM +0530, Madhur Kumar wrote:
> Replace the use of __i386__ and __x86_64__ with CONFIG_X86 to adhere to
> kernel coding guideline, make the code more portable and integrates
> better with the Kconfig system.
> 
> Signed-off-by: Madhur Kumar <redacted>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 02860d3ec..67a2f6044 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
>  		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
>  		poke32(VGA_CONFIGURATION, reg);
>  	} else {
> -#if defined(__i386__) || defined(__x86_64__)
> +#ifdef CONFIG_X86
>  		/* set graphic mode via IO method */
>  		outb_p(0x88, 0x3d4);
>  		outb_p(0x06, 0x3d5);
> -- 
> 2.48.1
> 
> 

Does not apply to my tree at all :(
```