[PATCH] fbdev: efifb: Change the return value type to void

Subsystems: efifb framebuffer driver, framebuffer layer, the rest

STALE646d

2 messages, 2 authors, 2025-01-08 · open the first message on its own page

[PATCH] fbdev: efifb: Change the return value type to void

From: <hidden>
Date: 2025-01-03 03:26:46

From: Shixiong Ou <redacted>

efifb_setup() doesn't need to return a value.

Signed-off-by: Shixiong Ou <redacted>
---
 drivers/video/fbdev/efifb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 20517448487e..0e1bd3dba255 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -275,7 +275,7 @@ static const struct fb_ops efifb_ops = {
 	.fb_setcolreg	= efifb_setcolreg,
 };
 
-static int efifb_setup(struct screen_info *si, char *options)
+static void efifb_setup(struct screen_info *si, char *options)
 {
 	char *this_opt;
 
@@ -299,8 +299,6 @@ static int efifb_setup(struct screen_info *si, char *options)
 				use_bgrt = false;
 		}
 	}
-
-	return 0;
 }
 
 static inline bool fb_base_is_valid(struct screen_info *si)
-- 
2.25.1

Re: [PATCH] fbdev: efifb: Change the return value type to void

From: Helge Deller <deller@gmx.de>
Date: 2025-01-08 23:30:30

On 1/3/25 04:26, oushixiong1025@163.com wrote:
From: Shixiong Ou <redacted>

efifb_setup() doesn't need to return a value.

Signed-off-by: Shixiong Ou <redacted>
applied.

Thanks!
Helge
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help