# Re: \[PATCH v5 1/3\] VT: Use macros to define ioctls

- From: Jiri Slaby \<jirislaby@kernel.org\>
- Date: 2024-05-29 07:29:27 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2024/05/2618389
- Thread: https://ratatoskr.run/linux-api/2024/02/2511580/t.md

```text
On 18. 04. 24, 8:18, Greg Kroah-Hartman wrote:
> On Wed, Apr 17, 2024 at 07:37:35PM +0200, Alexey Gladkov wrote:
>> All other headers use _IOC() macros to describe ioctls for a long time
>> now. This header is stuck in the last century.
>>
>> Simply use the _IO() macro. No other changes.
>>
>> Signed-off-by: Alexey Gladkov <legion@kernel.org>
>> ---
>>   include/uapi/linux/kd.h | 96 +++++++++++++++++++++--------------------
>>   1 file changed, 49 insertions(+), 47 deletions(-)
>
> This is a nice cleanup, thanks for doing it, I'll just take this one
> change now if you don't object.

Unfortunately, _IOC_NONE is 1 on some archs as noted by Arnd, and this commit changed the kd ioctl values in there which broke stuff as noted by Al.

We either:
* use _IOC(0, X, Y) in here, instead of _IO(X, Y), or
* define KDIOC(X) as _IOC(0, KD_IOCTL_BASE, X), or
* revert the commit which landed to -rc1 already.

thanks,
-- 
js

```