# Re: \[01/43\] drm/fbdev-generic: Do not set physical framebuffer address

- From: Sui Jingfeng \<hidden\>
- Date: 2024-03-18 22:22:31 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2024/03/6997814
- Thread: https://ratatoskr.run/linux-fbdev/2024/03/9246131/t/2.md

```text
Hi,


On 2024/3/12 23:44, Thomas Zimmermann wrote:
> Framebuffer memory is allocated via vmalloc() from non-contiguous
> physical pages. The physical framebuffer start address is therefore
> meaningless. Do not set it.
>
> The value is not used within the kernel and only exported to userspace
> on dedicated ARM configs. No functional change is expected.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: a5b44c4adb16 ("drm/fbdev-generic: Always use shadow buffering")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Zack Rusin <redacted>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: <redacted> # v6.4+
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>


Reviewed-by: Sui Jingfeng <redacted>

Tested-by: Sui Jingfeng <redacted>

-- 
Best regards,
Sui

```
