[PATCH] backlight: ktd2801: make timing struct static

Subsystems: backlight class/subsystem, framebuffer layer, ktd2801 backlight driver, the rest

STALE929d LANDED

Landed in mainline as 7534904d421e on 2024-03-07.

3 messages, 3 authors, 2024-02-23 · open the first message on its own page

[PATCH] backlight: ktd2801: make timing struct static

From: Duje Mihanović <duje.mihanovic@skole.hr>
Date: 2024-02-10 16:23:23

The struct containing the KTD2801 timing can be made static as it's not
referenced outside the KTD2801 driver. Do this to prevent sparse
complaints.

Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
 drivers/video/backlight/ktd2801-backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/ktd2801-backlight.c b/drivers/video/backlight/ktd2801-backlight.c
index c020acff40f1..d295c2766025 100644
--- a/drivers/video/backlight/ktd2801-backlight.c
+++ b/drivers/video/backlight/ktd2801-backlight.c
@@ -13,7 +13,7 @@
 #define KTD2801_MAX_BRIGHTNESS		255
 
 /* These values have been extracted from Samsung's driver. */
-const struct expresswire_timing ktd2801_timing = {
+static const struct expresswire_timing ktd2801_timing = {
 	.poweroff_us = 2600,
 	.detect_delay_us = 150,
 	.detect_us = 270,
---
base-commit: 66c76c1cd984c14660453dfa2118014817924375
change-id: 20240210-ktd2801-static-e1c23d19600c

Best regards,
-- 
Duje Mihanović [off-list ref]

Re: [PATCH] backlight: ktd2801: make timing struct static

From: Daniel Thompson <hidden>
Date: 2024-02-12 10:54:41

On Sat, Feb 10, 2024 at 05:16:17PM +0100, Duje Mihanović wrote:
The struct containing the KTD2801 timing can be made static as it's not
referenced outside the KTD2801 driver. Do this to prevent sparse
complaints.

Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
Reviewed-by: Daniel Thompson <redacted>


Daniel.

Re: (subset) [PATCH] backlight: ktd2801: make timing struct static

From: Lee Jones <lee@kernel.org>
Date: 2024-02-23 14:50:30

On Sat, 10 Feb 2024 17:16:17 +0100, Duje Mihanović wrote:
The struct containing the KTD2801 timing can be made static as it's not
referenced outside the KTD2801 driver. Do this to prevent sparse
complaints.
Applied, thanks!

[1/1] backlight: ktd2801: make timing struct static
      commit: ed2ac75acf99d33444a5d440fcad4261ad6f0d5c

--
Lee Jones [李琼斯]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help