# Re: \[PATCH 1/8\] fbdev/smscufx: Use fb\_ops helpers for deferred I/O

- From: Thomas Zimmermann \<tzimmermann@suse.de\>
- Date: 2023-09-04 14:45:28 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/09/8935631
- Thread: https://ratatoskr.run/linux-fbdev/2023/08/8935599/t.md

```text


Am 04.09.23 um 16:39 schrieb Thomas Zimmermann:
[...]
> At least two drivers could use __FB_DEFAULT_DEFERRED_OPS_MMAP: picolcd-fb and hyperv_fb. At some point, we might want to set/clear

Both drivers are already in this patchset.

> fb_mmap depending on some Kconfig value. Having __FB_DEFAULT_DEFERRED_OPS_MMAP might be helpful then.
>
>>
>> Alternatively, __FB_DEFAULT_DEFERRED_OPS_MMAP() could still be left but
>> not taking a __prefix argument since that is not used anyways ?
>
> The driver optionally provides mmap without deferred I/O, hence the mmap function. That makes no sense, as these writes to the buffer would never make it to the device memory. But I didn't want to remove the code either. So I just left the existing function as-is. Usually, the deferred-I/O mmap is called immediately. [1]
>
> Best regards
> Thomas
>
> [1] https://elixir.bootlin.com/linux/v6.5.1/source/drivers/video/fbdev/smscufx.c#L784
>
>>
>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
```

## Attachments

- [OpenPGP\_signature](https://ratatoskr.run/linux-fbdev/2023/09/8935631/attachment/0) (application/pgp-signature, 840 bytes)
