[PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

Subsystems: framebuffer layer, the rest

STALE1101d

3 messages, 3 authors, 2023-08-31 · open the first message on its own page

[PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2023-08-31 12:06:02

The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo
are flags that can have only two possible values: 0 and 1.
Reduce kernel size by changing their types from int to bool.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/video/fbdev/ssd1307fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 86dd24022871a843..5ae48e36fccb4e8d 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -52,8 +52,8 @@ struct ssd1307fb_deviceinfo {
 	u32 default_vcomh;
 	u32 default_dclk_div;
 	u32 default_dclk_frq;
-	int need_pwm;
-	int need_chargepump;
+	bool need_pwm;
+	bool need_chargepump;
 };
 
 struct ssd1307fb_par {
-- 
2.34.1

Re: [PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-08-31 17:39:20

Geert Uytterhoeven [off-list ref] writes:
The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo
are flags that can have only two possible values: 0 and 1.
Reduce kernel size by changing their types from int to bool.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Acked-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

From: Helge Deller <deller@gmx.de>
Date: 2023-08-31 21:40:49

On 8/31/23 14:05, Geert Uytterhoeven wrote:
The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo
are flags that can have only two possible values: 0 and 1.
Reduce kernel size by changing their types from int to bool.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
applied to fbdev git tree.

Thanks!
Helge
quoted hunk
---
  drivers/video/fbdev/ssd1307fb.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 86dd24022871a843..5ae48e36fccb4e8d 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -52,8 +52,8 @@ struct ssd1307fb_deviceinfo {
  	u32 default_vcomh;
  	u32 default_dclk_div;
  	u32 default_dclk_frq;
-	int need_pwm;
-	int need_chargepump;
+	bool need_pwm;
+	bool need_chargepump;
  };

  struct ssd1307fb_par {

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help