mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

Hi All,

The latest mainline kernel branch fails to build mips jazz_defconfig with
the error:

drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'?
  115 |         FB_DEFAULT_IOMEM_HELPERS,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
      |         FB_DEFAULT_IOMEM_OPS


git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers").

Reverting the commit has fixed the build failure.

I will be happy to test any patch or provide any extra log if needed.

#regzbot introduced: 5011260838551cefbf23d60b48c3243b6d5530a2

-- 
Regards
Sudip

On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink)
[off-list ref] wrote:

The latest mainline kernel branch fails to build mips jazz_defconfig with
the error:

drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'?
  115 |         FB_DEFAULT_IOMEM_HELPERS,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
      |         FB_DEFAULT_IOMEM_OPS


git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers").

Reverting the commit has fixed the build failure.

I will be happy to test any patch or provide any extra log if needed.

Would you mind testing the exact thing that the compiler suggested?

So instead of the revert, just replace FB_DEFAULT_IOMEM_HELPERS with
FB_DEFAULT_IOMEM_OPS.

I think it's just a typo / confusion with the config variable (which
is called FB_IOMEM_HELPERS).

               Linus

On Thu, 31 Aug 2023 at 20:04, Linus Torvalds
[off-list ref] wrote:

On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink)
[off-list ref] wrote:

quoted

The latest mainline kernel branch fails to build mips jazz_defconfig with
the error:

drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'?
  115 |         FB_DEFAULT_IOMEM_HELPERS,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
      |         FB_DEFAULT_IOMEM_OPS


git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers").

Reverting the commit has fixed the build failure.

I will be happy to test any patch or provide any extra log if needed.

Would you mind testing the exact thing that the compiler suggested?

So instead of the revert, just replace FB_DEFAULT_IOMEM_HELPERS with
FB_DEFAULT_IOMEM_OPS.

I think it's just a typo / confusion with the config variable (which
is called FB_IOMEM_HELPERS).

Yeah, you were right.
Patch sent - https://lore.kernel.org/lkml/20230902095102.5908-1-sudip.mukherjee@codethink.co.uk/


-- 
Regards
Sudip

[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]

On 31.08.23 20:48, Sudip Mukherjee (Codethink) wrote:

Hi All,

The latest mainline kernel branch fails to build mips jazz_defconfig with
the error:

drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'?
  115 |         FB_DEFAULT_IOMEM_HELPERS,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
      |         FB_DEFAULT_IOMEM_OPS


git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers").

Reverting the commit has fixed the build failure.

I will be happy to test any patch or provide any extra log if needed.

#regzbot introduced: 5011260838551cefbf23d60b48c3243b6d5530a2

#regzbot fix: 8df0f84c3bb921f5aa1036223dd932bbc7df6d
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.