# Re: \[PATCH 2/4\] vgacon: rework screen\_info \#ifdef checks

- From: Thomas Bogendoerfer \<tsbogend@alpha.franken.de\>
- Date: 2023-07-08 14:12:20 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/07/2257913
- Thread: https://ratatoskr.run/linux-fbdev/2023/07/2257062/t.md

```text
On Fri, Jul 07, 2023 at 11:52:24AM +0200, Arnd Bergmann wrote:
> diff --git a/arch/mips/jazz/setup.c b/arch/mips/jazz/setup.c
> index ee044261eb223..3c14548353e47 100644
> --- a/arch/mips/jazz/setup.c
> +++ b/arch/mips/jazz/setup.c
> @@ -76,7 +76,7 @@ void __init plat_mem_setup(void)
>  
>  	_machine_restart = jazz_machine_restart;
>  
> -#ifdef CONFIG_VT
> +#ifdef CONFIG_VGA_CONSOLE
>  	screen_info = (struct screen_info) {
>  		.orig_video_cols	= 160,
>  		.orig_video_lines	= 64,

that wssn't intended for VGA but for fbdev/g364fb, which doesn't use
it. So removing it is probably the best thing.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
```