# Re: \[PATCH 13/30\] fbdev/metronomefb: Use hardware device for dev\_err()

- From: Javier Martinez Canillas \<javierm@redhat.com\>
- Date: 2023-06-07 09:01:48 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/06/9235966
- Thread: https://ratatoskr.run/linux-fbdev/2023/06/9235806/t.md

```text
Thomas Zimmermann [ref] writes:

> Replace the use of the fbdev software device, stored in struct
> fb_info.dev, with the hardware device from struct fb_info.device
> in load_waveform(). The device is only used for printing errors
> with dev_err().
>
> This change aligns load_waveform() with the rest of the driver and
> prepares fbdev for making struct fb_info.dev optional.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

```