# Re: \[PATCH 11/30\] fbdev/ep93xx-fb: Do not assign to struct fb\_info.dev

- From: Javier Martinez Canillas \<javierm@redhat.com\>
- Date: 2023-06-07 09:00:26 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/06/9235964
- Thread: https://ratatoskr.run/linux-fbdev/2023/06/9235806/t.md

```text
Thomas Zimmermann [ref] writes:

> Do not assing the Linux device to struct fb_info.dev. The call to
> register_framebuffer() initializes the field to the fbdev device.
> Drivers should not override its value.
>
> Fixes a bug where the driver incorrectly decreases the hardware
> device's reference counter and leaks the fbdev device.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

```