# Re: \[PATCH 01/30\] backlight/bd6107: Compare against struct fb\_info.device

- From: Javier Martinez Canillas \<javierm@redhat.com\>
- Date: 2023-06-07 07:31:08 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/06/9235947
- Thread: https://ratatoskr.run/linux-fbdev/2023/06/9235806/t.md

```text
Thomas Zimmermann [ref] writes:

> Struct bd6107_platform_data refers to a platform device within
> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
> compares it against the fbdev device in struct fb_info.dev, which
> is different. Fix the test by comparing to struct fb_info.device.
>
> Fixes a bug in the backlight driver and prepares fbdev for making
> struct fb_info.dev optional.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Daniel Thompson <redacted>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

```