# Re: \[PATCH 02/30\] backlight/gpio\_backlight: Compare against struct fb\_info.device

- From: Sam Ravnborg \<hidden\>
- Date: 2023-06-05 20:23:16 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/06/9235852
- Thread: https://ratatoskr.run/linux-sh/2023/06/9235806/t.md

```text
Hi Michael.

> >
> >Fixes a bug in the backlight driver and prepares fbdev for making
> >struct fb_info.dev optional.
> 
> I only see a rename from fbdev  to dev...
> 
> Is there missing code?
> 
> Would  a fixes: be useful?
> 
> M
> 
> >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct
> >backlight_device *bl,
> > {
> > 	struct gpio_backlight *gbl = bl_get_data(bl);
> >
> >-	return gbl->fbdev == NULL || gbl->fbdev == info->dev;
> >+	return !gbl->dev || gbl->dev == info->device;
> > }

The real change is here where info->dev is replaced by info->device.

	Sam
```