# Re: \[PATCH v2 34/38\] fbdev/core: Add fb\_device\_{create,destroy}()

- From: Sam Ravnborg \<hidden\>
- Date: 2023-06-12 15:45:06 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/06/2230198
- Thread: https://ratatoskr.run/linux-fbdev/2023/06/2230006/t.md

```text
On Mon, Jun 12, 2023 at 04:08:12PM +0200, Thomas Zimmermann wrote:
> Move the logic to create and destroy fbdev devices into the new
> helpers fb_device_create() and fb_device_destroy().
> 
> There was a call to fb_cleanup_device() in do_unregister_framebuffer()
> that was too late. The device had already been removed at this point.
> Move the call into fb_device_destroy().
> 
> Declare the helpers in the new internal header file  fb_internal.h, as
> they are only used within the fbdev core module.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <redacted>
```