# Re: \[PATCH\] fbdev: i810: include i810\_main.h in i810\_dvt.c

- From: Helge Deller \<deller@gmx.de\>
- Date: 2023-05-19 14:34:34 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/05/2203497
- Thread: https://ratatoskr.run/linux-fbdev/2023/05/2199894/t.md

```text
On 5/17/23 10:46, Jani Nikula wrote:
> On Tue, 16 May 2023, Arnd Bergmann [ref] wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Building with W=1 shows that a header needs to be included to
>> make the prototypes visible:
>>
>> drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype for 'round_off_xres' [-Werror=missing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:233:6: error: no previous prototype for 'i810fb_encode_registers' [-Werror=missing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:245:6: error: no previous prototype for 'i810fb_fill_var_timings' [-Werror=missing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:279:5: error: no previous prototype for 'i810_get_watermark' [-Werror=missing-prototypes]
>>
>> Adding the header leads to another warning from a mismatched
>> prototype, so fix this as well:
>>
>> drivers/video/fbdev/i810/i810_dvt.c:280:5: error: conflicting types for 'i810_get_watermark'; have 'u32(struct fb_var_screeninfo *,
>
> Changes here look fine,
>
> Reviewed-by: Jani Nikula <redacted>

applied to fbdev tree.

Thanks!
Helge
```
