# Re: \[PATCH v3 4/6\] fbdev: Include \<linux/io.h\> via \<asm/fb.h\>

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2023-05-03 08:53:28 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/05/2186377
- Thread: https://ratatoskr.run/linux-arch/2023/05/2185709/t.md

```text
On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote:
> Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann [ref] writes:
>>>>
>>>> There are countless examples where the above are not followed,
>>>> but to my best understanding the above it the preferred way to do it.
>>>
>>> Where did youher this? I only know about this in the case of asm/io.h
>>> vs. linux/io.h.
>>>
>> 
>> I understand that's the case too. I believe even checkpatch.pl complains
>> about it? (not that the script always get right, but just as an example).
>
> Do you know if that's the general rule? If so, we might want to 
> repurpose <asm/fbio.h> for the framebuffer I/O functions.

It's certainly the general trend across all of the kernel to have
drivers prefer including linux/*.h, and to move stuff from asm/*.h
to linux/*.h as it gets generalized across architectures.

     Arnd
```