# Re: \[PATCH 11/15\] powerpc: via-pmu-backlight: Introduce backlight\_get\_brightness()

- From: Stephen Kitt \<hidden\>
- Date: 2023-01-08 19:42:51 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2023/01/2058843
- Thread: https://ratatoskr.run/linux-fbdev/2023/01/2058457/t.md

```text
On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint
[ref] wrote:

> From: Sam Ravnborg <redacted>
> 
> Introduce backlight_get_brightness() to simplify logic
> and avoid direct access to backlight properties.
> 
> Signed-off-by: Sam Ravnborg <redacted>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Sam Ravnborg <redacted>
> Cc: <redacted>
> ---
>  drivers/macintosh/via-pmu-backlight.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/macintosh/via-pmu-backlight.c
> b/drivers/macintosh/via-pmu-backlight.c index 2194016122d2..c2d87e7fa85b
> 100644 --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level)
>  static int __pmu_backlight_update_status(struct backlight_device *bd)
>  {
>  	struct adb_request req;
> -	int level = bd->props.brightness;
> -
> -
> -	if (bd->props.power != FB_BLANK_UNBLANK ||
> -	    bd->props.fb_blank != FB_BLANK_UNBLANK)
> -		level = 0;
> +	int level = backlight_get_brightness(bd);
>  
>  	if (level > 0) {
>  		int pmulevel = pmu_backlight_get_level_brightness(level);
> 
> -- 
> 2.34.1

This one is already in 6.2-rc1, it went in via powerpc/next.

Regards,

Stephen
```

## Attachments

- [(unnamed)](https://ratatoskr.run/linux-fbdev/2023/01/2058843/attachment/0) (application/pgp-signature, 833 bytes)