[PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()

Subsystems: framebuffer layer, the rest

STALE1375d

2 messages, 2 authors, 2022-11-07 · open the first message on its own page

[PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()

From: <hidden>
Date: 2022-11-06 14:21:07

Eliminate the follow coccicheck warning:

./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
platform_get_irq() already prints an error

Signed-off-by: KaiLong Wang <redacted>
---
 drivers/video/fbdev/pxafb.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 696ac5431180..c46ed78298ae 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
 
 	irq = platform_get_irq(dev, 0);
 	if (irq < 0) {
-		dev_err(&dev->dev, "no IRQ defined\n");
 		ret = -ENODEV;
 		goto failed_free_mem;
 	}
-- 
2.25.1

Re: [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()

From: Helge Deller <deller@gmx.de>
Date: 2022-11-07 08:52:58

On 11/6/22 15:16, wangkailong@jari.cn wrote:
Eliminate the follow coccicheck warning:

./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
platform_get_irq() already prints an error

Signed-off-by: KaiLong Wang <redacted>
applied.
Thanks!
Helge
quoted hunk
---
  drivers/video/fbdev/pxafb.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 696ac5431180..c46ed78298ae 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)

  	irq = platform_get_irq(dev, 0);
  	if (irq < 0) {
-		dev_err(&dev->dev, "no IRQ defined\n");
  		ret = -ENODEV;
  		goto failed_free_mem;
  	}

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help