# Re: \[PATCH printk v2 38/38\] printk, xen: fbfront: create/use safe function for forcing preferred

- From: John Ogness \<john.ogness@linutronix.de\>
- Date: 2022-10-27 13:35:33 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2022/10/1984343
- Thread: https://ratatoskr.run/linux-fbdev/2022/10/237459/t.md

```text
On 2022-10-27, Petr Mladek [ref] wrote:
>> -	if (c) {
>> -		unregister_console(c);
>> -		c->flags |= CON_CONSDEV;
>> -		c->flags &= ~CON_PRINTBUFFER; /* don't print again */
>> -		register_console(c);
>> -	}
>> +	if (c)
>> +		console_force_preferred(c);
>
> I would prefer to fix this a clean way.
>
> [...]
>
> I would suggest to implement:
>
> [...]
>
> It is a more code. But it is race-free. Also it is much more clear
> what is going on.
>
> How does this sound, please?

I wasn't sure if any of the other preferred-console magic in
register_console() was needed, which is why I kept a full
register_console() call. But if it really is just about forcing it the
head and setting a new CON_CONSDEV, then your suggestion is much
simpler. Thanks.

John
```