# Re: \[PATCH 10/11\] fbdev: Acquire framebuffer apertures for firmware devices

- From: Thomas Zimmermann \<tzimmermann@suse.de\>
- Date: 2022-07-15 11:58:23 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2022/07/9222105
- Thread: https://ratatoskr.run/linux-fbdev/2022/07/9221570/t.md

```text
Hi

Am 11.07.22 um 13:29 schrieb Javier Martinez Canillas:
> On 7/7/22 17:39, Thomas Zimmermann wrote:
>> When registering a generic framebuffer, automatically acquire ownership
>> of the framebuffer's I/O range. The device will now be handled by the
>> aperture helpers. Fbdev-based conflict handling is no longer required.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   drivers/video/fbdev/core/fbmem.c | 33 ++++++++++++++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
>>
>> diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
>> index 2237049327db..e556ad69f48f 100644
>> --- a/drivers/video/fbdev/core/fbmem.c
>> +++ b/drivers/video/fbdev/core/fbmem.c
>> @@ -13,6 +13,7 @@
>>   
>>   #include <linux/module.h>
>>   
>> +#include <linux/aperture.h>
>>   #include <linux/compat.h>
>>   #include <linux/types.h>
>>   #include <linux/errno.h>
>> @@ -1739,6 +1740,32 @@ static void do_unregister_framebuffer(struct fb_info *fb_info)
>>   	put_fb_info(fb_info);
>>   }
>>   
>> +static int fbm_aperture_acquire_for_platform_device(struct fb_info *fb_info)
>> +{
>
> What's the meaning of 'm' here ? Misc, memory ? I would just call it 'fb_'.

'managed' as in drmm_ But using fb_ is also good. I actually wasn't sure about this naming.

Best regards
Thomas

>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
```

## Attachments

- [OpenPGP\_signature](https://ratatoskr.run/linux-fbdev/2022/07/9222105/attachment/0) (application/pgp-signature, 840 bytes)