# Re: \[PATCH 1/7\] fbdev: aty128fb: Use backlight helper

- From: Sam Ravnborg \<hidden\>
- Date: 2022-06-10 20:29:25 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2022/06/1815420
- Thread: https://ratatoskr.run/linux-fbdev/2022/06/1811307/t.md

```text
Hi Stepehen,

On Tue, Jun 07, 2022 at 09:23:29PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Signed-off-by: Stephen Kitt <redacted>
> Cc: Paul Mackerras <redacted>
> Cc: Helge Deller <deller@gmx.de>
> Cc: <redacted>
> Cc: <redacted>

This and the other 6 patches in this series are all:
Reviewed-by: Sam Ravnborg <redacted>

I did not receive the cover letter, which is why I reply to this mail.

	Sam
```
