From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: 2022-03-04 20:01:15
In the fbtft_init_display() the init sequence is printed for
the debug purposes. Unfortunately the current code doesn't take
into account that values in the buffer are of the s16 type.
Consider that and replace the printing code with fbtft_par_dbg_hex()
call.
Fixes: b888897014a9 ("staging/fbtft: Remove all strcpy() uses")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/staging/fbtft/fbtft-core.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: 2022-03-08 10:19:14
+Cc: Helge
Maybe you can pick this up?
On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
quoted hunk
In the fbtft_init_display() the init sequence is printed for
the debug purposes. Unfortunately the current code doesn't take
into account that values in the buffer are of the s16 type.
Consider that and replace the printing code with fbtft_par_dbg_hex()
call.
Fixes: b888897014a9 ("staging/fbtft: Remove all strcpy() uses")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/staging/fbtft/fbtft-core.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
On Tue, Mar 08, 2022 at 12:18:25PM +0200, Andy Shevchenko wrote:
+Cc: Helge
Maybe you can pick this up?
On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
You sent this less than a week ago! Please relax, staging driver
patches are way down my list of priorities at the moment. Wait at least
2 weeks before trying to get someone else to take patches for this
subsystem.
relax...
greg k-h
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: 2022-03-08 12:14:45
On Tue, Mar 08, 2022 at 11:46:32AM +0100, Greg Kroah-Hartman wrote:
On Tue, Mar 08, 2022 at 12:18:25PM +0200, Andy Shevchenko wrote:
quoted
+Cc: Helge
Maybe you can pick this up?
On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
You sent this less than a week ago! Please relax, staging driver
patches are way down my list of priorities at the moment. Wait at least
2 weeks before trying to get someone else to take patches for this
subsystem.
relax...
Ah, okay. Sorry, I was browsing my long mailbox and haven't paid attention on
the date I had sent this one on.
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
quoted hunk
In the fbtft_init_display() the init sequence is printed for
the debug purposes. Unfortunately the current code doesn't take
into account that values in the buffer are of the s16 type.
Consider that and replace the printing code with fbtft_par_dbg_hex()
call.
Fixes: b888897014a9 ("staging/fbtft: Remove all strcpy() uses")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/staging/fbtft/fbtft-core.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
Any reason you didn't test build this?
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_init_display’:
drivers/staging/fbtft/fbtft-core.c:1038:48: error: passing argument 3 of ‘fbtft_dbg_hex’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
1038 | s16, &par->init_sequence[i + 1], j,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/fbtft/fbtft.h:441:50: note: in definition of macro ‘fbtft_par_dbg_hex’
441 | fbtft_dbg_hex(dev, sizeof(type), buf,\
| ^~~
drivers/staging/fbtft/fbtft-core.c:52:26: note: expected ‘void *’ but argument is of type ‘const s16 *’ {aka ‘const short int *’}
52 | void *buf, size_t len, const char *fmt, ...)
| ~~~~~~^~~
LD [M] drivers/staging/gdm724x/gdmulte.o
cc1: all warnings being treated as errors