# \[PATCH\] fbdev: omap2: omapfb: Remove redundant 'flush\_workqueue()' calls

- From: Xu Wang \<hidden\>
- Date: 2022-01-13 07:48:00 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2022/01/9212264
- Thread: https://ratatoskr.run/dri-devel/2022/01/9212264/t.md

```text
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <redacted>
---
 drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
index a3decc7fadde..afa688e754b9 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
@@ -1854,7 +1854,6 @@ static void omapfb_free_resources(struct omapfb2_device *fbdev)
 	}
 
 	if (fbdev->auto_update_wq != NULL) {
-		flush_workqueue(fbdev->auto_update_wq);
 		destroy_workqueue(fbdev->auto_update_wq);
 		fbdev->auto_update_wq = NULL;
 	}
-- 
2.25.1

```
