# Re: \[PATCH 5/5\] spi: make remove callback a void function

- From: Stefan Schmidt \<stefan@datenfreihafen.org\>
- Date: 2022-01-25 09:49:56 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2022/01/1646707
- Thread: https://ratatoskr.run/linux-integrity/2022/01/1646707/t.md

```text

Hello.

On 23.01.22 18:52, Uwe Kleine-König wrote:
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <redacted>
> ---

[...]

>   drivers/net/ieee802154/adf7242.c                      |  4 +---
>   drivers/net/ieee802154/at86rf230.c                    |  4 +---
>   drivers/net/ieee802154/ca8210.c                       |  6 ++----
>   drivers/net/ieee802154/cc2520.c                       |  4 +---
>   drivers/net/ieee802154/mcr20a.c                       |  4 +---
>   drivers/net/ieee802154/mrf24j40.c                     |  4 +---

[...]

For the ieee802154 drivers:

Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

regards
Stefan Schmidt
```
