[PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls

Subsystems: backlight class/subsystem, framebuffer layer, the rest

STALE1713d

2 messages, 2 authors, 2022-01-13 · open the first message on its own page

[PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls

From: Xu Wang <hidden>
Date: 2022-01-13 08:48:49

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <redacted>
---
 drivers/video/backlight/lm3630a_bl.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index e8b185bb6f5e..1d17c439430e 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -594,7 +594,6 @@ static int lm3630a_remove(struct i2c_client *client)
 
 	if (pchip->irq) {
 		free_irq(pchip->irq, pchip);
-		flush_workqueue(pchip->irqthread);
 		destroy_workqueue(pchip->irqthread);
 	}
 	return 0;
-- 
2.25.1

Re: [PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls

From: Daniel Thompson <hidden>
Date: 2022-01-13 15:02:42

On Thu, Jan 13, 2022 at 08:48:06AM +0000, Xu Wang wrote:
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <redacted>
Reviewed-by: Daniel Thompson <redacted>


Daniel.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help