# \[PATCH v1 1/1\] backlight: lm3630a\_bl: Put fwnode in error case during -\>probe()

- Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds
- List: linux-fbdev
- 4 messages, 4 authors
- Page: https://ratatoskr.run/linux-fbdev/2021/05/6362277/t

## \[PATCH v1 1/1\] backlight: lm3630a\_bl: Put fwnode in error case during -\>probe()

- From: Andy Shevchenko \<hidden\>
- Date: 2021-05-10 09:57:25 
- Message: https://ratatoskr.run/linux-fbdev/2021/05/6362277.md

```text
device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
Cc: Brian Masney <redacted>
Cc: Dan Murphy <redacted>
Signed-off-by: Andy Shevchenko <redacted>
---
 drivers/video/backlight/lm3630a_bl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index e88a2b0e5904..662029d6a3dc 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -482,8 +482,10 @@ static int lm3630a_parse_node(struct lm3630a_chip *pchip,
 
 	device_for_each_child_node(pchip->dev, node) {
 		ret = lm3630a_parse_bank(pdata, node, &seen_led_sources);
-		if (ret)
+		if (ret) {
+			fwnode_handle_put(node);
 			return ret;
+		}
 	}
 
 	return ret;
-- 
2.31.1

```

## Re: \[PATCH v1 1/1\] backlight: lm3630a\_bl: Put fwnode in error case during -\>probe()

- From: Brian Masney \<hidden\>
- Date: 2021-05-10 11:11:00 
- Message: https://ratatoskr.run/linux-fbdev/2021/05/6362769.md

```text
On Mon, May 10, 2021 at 12:57:16PM +0300, Andy Shevchenko wrote:
> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.
> 
> Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
> Cc: Brian Masney <redacted>
> Cc: Dan Murphy <redacted>
> Signed-off-by: Andy Shevchenko <redacted>

Reviewed-by: Brian Masney <redacted>

```

## Re: \[PATCH v1 1/1\] backlight: lm3630a\_bl: Put fwnode in error case during -\>probe()

- From: Daniel Thompson \<hidden\>
- Date: 2021-05-13 10:38:02 
- Message: https://ratatoskr.run/linux-fbdev/2021/05/1376568.md

```text
On Mon, May 10, 2021 at 12:57:16PM +0300, Andy Shevchenko wrote:
> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.
> 
> Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
> Cc: Brian Masney <redacted>
> Cc: Dan Murphy <redacted>
> Signed-off-by: Andy Shevchenko <redacted>

Reviewed-by: Daniel Thompson <redacted>


> ---
>  drivers/video/backlight/lm3630a_bl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index e88a2b0e5904..662029d6a3dc 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -482,8 +482,10 @@ static int lm3630a_parse_node(struct lm3630a_chip *pchip,
>  
>  	device_for_each_child_node(pchip->dev, node) {
>  		ret = lm3630a_parse_bank(pdata, node, &seen_led_sources);
> -		if (ret)
> +		if (ret) {
> +			fwnode_handle_put(node);
>  			return ret;
> +		}
>  	}
>  
>  	return ret;
> -- 
> 2.31.1
> 
```

## Re: \[PATCH v1 1/1\] backlight: lm3630a\_bl: Put fwnode in error case during -\>probe()

- From: Lee Jones \<hidden\>
- Date: 2021-05-19 14:33:34 
- Message: https://ratatoskr.run/linux-fbdev/2021/05/1383545.md

```text
On Mon, 10 May 2021, Andy Shevchenko wrote:

> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.
> 
> Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
> Cc: Brian Masney <redacted>
> Cc: Dan Murphy <redacted>
> Signed-off-by: Andy Shevchenko <redacted>
> ---
>  drivers/video/backlight/lm3630a_bl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
```