# \[PATCH -next\] video: fbdev: intelfb: Remove set but not used variable 'val' - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 1 author - Page: https://ratatoskr.run/linux-fbdev/2021/05/1393677/t ## \[PATCH -next\] video: fbdev: intelfb: Remove set but not used variable 'val' - From: Baokun Li \ - Date: 2021-05-27 08:50:01 - Message: https://ratatoskr.run/linux-fbdev/2021/05/1393677.md ```text Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setscl': drivers/video/fbdev/intelfb/intelfb_i2c.c:58:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setsda': drivers/video/fbdev/intelfb/intelfb_i2c.c:69:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] It never used since introduction. Signed-off-by: Baokun Li --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d9d7..4df2f1f8a18e 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state) { struct intelfb_i2c_chan *chan = data; struct intelfb_info *dinfo = chan->dinfo; - u32 val; OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) | SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK); - val = INREG(chan->reg); + INREG(chan->reg); } static void intelfb_gpio_setsda(void *data, int state) { struct intelfb_i2c_chan *chan = data; struct intelfb_info *dinfo = chan->dinfo; - u32 val; OUTREG(chan->reg, (state ? SDA_VAL_OUT : 0) | SDA_DIR | SDA_DIR_MASK | SDA_VAL_MASK); - val = INREG(chan->reg); + INREG(chan->reg); } static int intelfb_gpio_getscl(void *data) -- 2.25.4 ``` ## Re: \[PATCH -next\] video: fbdev: intelfb: Remove set but not used variable 'val' - From: libaokun (A) \ - Date: 2021-06-15 02:34:59 - Message: https://ratatoskr.run/linux-fbdev/2021/06/1414166.md ```text ping 在 2021/5/27 16:59, Baokun Li 写道: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setscl': > drivers/video/fbdev/intelfb/intelfb_i2c.c:58:6: warning: > variable ‘val’ set but not used [-Wunused-but-set-variable] > drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setsda': > drivers/video/fbdev/intelfb/intelfb_i2c.c:69:6: warning: > variable ‘val’ set but not used [-Wunused-but-set-variable] > > It never used since introduction. > > Signed-off-by: Baokun Li > --- > drivers/video/fbdev/intelfb/intelfb_i2c.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c > index 3300bd31d9d7..4df2f1f8a18e 100644 > --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c > +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c > @@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state) > { > struct intelfb_i2c_chan *chan = data; > struct intelfb_info *dinfo = chan->dinfo; > - u32 val; > > OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) | > SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK); > - val = INREG(chan->reg); > + INREG(chan->reg); > } > > static void intelfb_gpio_setsda(void *data, int state) > { > struct intelfb_i2c_chan *chan = data; > struct intelfb_info *dinfo = chan->dinfo; > - u32 val; > > OUTREG(chan->reg, (state ? SDA_VAL_OUT : 0) | > SDA_DIR | SDA_DIR_MASK | SDA_VAL_MASK); > - val = INREG(chan->reg); > + INREG(chan->reg); > } > > static int intelfb_gpio_getscl(void *data) ```