# \[PATCH 04/44\] vgacon: comment on vga\_rolled\_over

- Subsystems: FRAMEBUFFER LAYER, CONSOLE SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Greg Kroah-Hartman, Linus Torvalds
- Status: LANDED (5a3c96e96409 · 2021-03-10 08:34)
- Landed in mainline as 5a3c96e96409 on 2021-03-10.
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2021/03/6284734/t

## \[PATCH 04/44\] vgacon: comment on vga\_rolled\_over

- From: Jiri Slaby \<hidden\>
- Date: 2021-03-02 08:24:39 
- Message: https://ratatoskr.run/linux-fbdev/2021/03/6284734.md

```text
Long time ago, I figured out what this number is good for and documented
that locally. But never submitted, so do it now.

Signed-off-by: Jiri Slaby <redacted>
Cc: <redacted>
Cc: <redacted>
---
 drivers/video/console/vgacon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 962c12be9774..0d26e821e73b 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -96,7 +96,7 @@ static bool 		vga_is_gfx;
 static bool 		vga_512_chars;
 static int 		vga_video_font_height;
 static int 		vga_scan_lines		__read_mostly;
-static unsigned int 	vga_rolled_over;
+static unsigned int 	vga_rolled_over; /* last vc_origin offset before wrap */
 
 static bool vgacon_text_mode_force;
 static bool vga_hardscroll_enabled;
-- 
2.30.1

```

## Re: \[PATCH 04/44\] vgacon: comment on vga\_rolled\_over

- From: Daniel Vetter \<hidden\>
- Date: 2021-03-11 13:09:01 
- Message: https://ratatoskr.run/linux-fbdev/2021/03/6296755.md

```text
On Tue, Mar 02, 2021 at 07:21:34AM +0100, Jiri Slaby wrote:
> Long time ago, I figured out what this number is good for and documented
> that locally. But never submitted, so do it now.
> 
> Signed-off-by: Jiri Slaby <redacted>
> Cc: <redacted>
> Cc: <redacted>

I think Greg volunteered to take care of these ... Also my brain is toast
and I'm not even close to ready to grok vc code to review this properly
:-/

Cheers, Daniel
> ---
>  drivers/video/console/vgacon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index 962c12be9774..0d26e821e73b 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -96,7 +96,7 @@ static bool 		vga_is_gfx;
>  static bool 		vga_512_chars;
>  static int 		vga_video_font_height;
>  static int 		vga_scan_lines		__read_mostly;
> -static unsigned int 	vga_rolled_over;
> +static unsigned int 	vga_rolled_over; /* last vc_origin offset before wrap */
>  
>  static bool vgacon_text_mode_force;
>  static bool vga_hardscroll_enabled;
> -- 
> 2.30.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
```
