From: Lee Jones <hidden> Date: 2021-01-13 14:51:14
Also fix a formatting issue
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/core/fbmon.c:617: warning: Function parameter or member 'specs' not described in 'fb_create_modedb'
drivers/video/fbdev/core/fbmon.c:1103: warning: bad line:
Cc: James Simmons <redacted>
Cc: Egbert Eich <redacted>
Cc: John Fremlin <redacted>
Cc: Ani Joshi <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/core/fbmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:33
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/riva/fbdev.c:485: warning: Function parameter or member 'data8' not described in 'rivafb_load_cursor_image'
drivers/video/fbdev/riva/fbdev.c:485: warning: Excess function parameter 'data' description in 'rivafb_load_cursor_image'
drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'var' not described in 'rivafb_do_maximize'
drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'nom' not described in 'rivafb_do_maximize'
drivers/video/fbdev/riva/fbdev.c:1229: warning: Excess function parameter 'con' description in 'rivafb_pan_display'
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Ani Joshi <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/riva/fbdev.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:34
If used, 'dac_type' is overwritten in the '#ifdef CONFIG_ATARI' clause.
It's also not used after the last assignment, so we'll rid that too.
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Alex Kern <redacted>
Cc: "Eddie C. Dost" <redacted>
Cc: Anthony Tong <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/atyfb_base.c | 3 ---
1 file changed, 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:34
Fixes the following W=1 kernel build warning(s):
drivers/video/of_display_timing.c:58: warning: Function parameter or member 'dt' not described in 'of_parse_display_timing'
Cc: Steffen Trumtrar <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/of_display_timing.c | 1 +
1 file changed, 1 insertion(+)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:58
Neither 'sis.h' nor any of its consumers uses these tables.
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sis/init.h:144:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:132:28: warning: ‘SiS_EGA_DAC’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:120:28: warning: ‘SiS_CGA_DAC’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:108:28: warning: ‘SiS_MDA_DAC’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:106:29: warning: ‘ModeIndex_310_2048x1536’ defined but not used [-Wunused-const-variable
drivers/video/fbdev/sis/init.h:105:29: warning: ‘ModeIndex_300_2048x1536’ defined but not used [-Wunused-const-variable
drivers/video/fbdev/sis/init.h:104:29: warning: ‘ModeIndex_1920x1440’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:103:29: warning: ‘ModeIndex_1920x1080’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:102:29: warning: ‘ModeIndex_1600x1200’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:101:29: warning: ‘ModeIndex_1680x1050’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/init.h:100:29: warning: ‘ModeIndex_1400x1050’ defined but not used [-Wunused-const-variable=]
NB: Snipped - there are 277 of these!
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sis/sis.h | 1 -
1 file changed, 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:58
'dac_type' is only used in the '#ifdef CONFIG_ATARI' clause.
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/aty/atyfb_base.c: In function ‘aty_init’:
drivers/video/fbdev/aty/atyfb_base.c:2363:6: warning: variable ‘dac_type’ set but not used [-Wunused-but-set-variable]
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Alex Kern <redacted>
Cc: "Eddie C. Dost" <redacted>
Cc: Anthony Tong <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/atyfb_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:59
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sis/init.c: In function ‘SiS_SetCRT1ModeRegs’:
drivers/video/fbdev/sis/init.c:2651:49: warning: variable ‘resindex’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’:
drivers/video/fbdev/sis/init.c:3544:19: warning: variable ‘A’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sis/init.c:3542:34: warning: variable ‘VBS’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sis/init.c:3541:34: warning: variable ‘HBS’ set but not used [-Wunused-but-set-variable]
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sis/init.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:59
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sis/sis_main.c: In function ‘sisfb_post_xgi_ddr2’:
drivers/video/fbdev/sis/sis_main.c:5032:5: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable]
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Gerd Knorr <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sis/sis_main.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:59
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sis/oem310.h:213:28: warning: ‘SiS_TVDelay661_301B’ defined but not used [-Wunused-const-variable=]
drivers/video/fbdev/sis/oem310.h:203:28: warning: ‘SiS_TVDelay661_301’ defined but not used [-Wunused-const-variable=]
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sis/oem310.h | 20 --------------------
1 file changed, 20 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:59
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVWriteAttr’:
drivers/video/fbdev/nvidia/nv_setup.c:92:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVReadAttr’:
drivers/video/fbdev/nvidia/nv_setup.c:104:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/nvidia/nv_setup.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:51:59
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'val' not described in 'fb_notifier_call_chain'
drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'v' not described in 'fb_notifier_call_chain'
Cc: Antonino Daplas <redacted>
Cc: Brad Douglas <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/core/fb_notify.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:52:21
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/neofb.c: In function ‘neo_init_hw’:
drivers/video/fbdev/neofb.c:1846:6: warning: variable ‘CursorMem’ set but not used [-Wunused-but-set-variable]
Cc: Evgeny Novikov <redacted>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Oliver Kropp <redacted>
Cc: "Thomas J. Moore" <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/neofb.c | 5 -----
1 file changed, 5 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:52:22
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/via/lcd.c: In function ‘viafb_lcd_set_mode’:
drivers/video/fbdev/via/lcd.c:540:29: warning: variable ‘mode_crt_table’ set but not used [-Wunused-but-set-variable]
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/via/lcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:52:23
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/cirrusfb.c: In function ‘WHDR’:
drivers/video/fbdev/cirrusfb.c:2466:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
Cc: Jeff Garzik <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/cirrusfb.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
@@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)WGen(cinfo,VGA_PEL_MSK,0x00);udelay(200);/* next read dummy from pixel address (3c8) */-dummy=RGen(cinfo,VGA_PEL_IW);+RGen(cinfo,VGA_PEL_IW);udelay(200);}/* now do the usual stuff to access the HDR */-dummy=RGen(cinfo,VGA_PEL_MSK);+RGen(cinfo,VGA_PEL_MSK);udelay(200);-dummy=RGen(cinfo,VGA_PEL_MSK);+RGen(cinfo,VGA_PEL_MSK);udelay(200);-dummy=RGen(cinfo,VGA_PEL_MSK);+RGen(cinfo,VGA_PEL_MSK);udelay(200);-dummy=RGen(cinfo,VGA_PEL_MSK);+RGen(cinfo,VGA_PEL_MSK);udelay(200);WGen(cinfo,VGA_PEL_MSK,val);
@@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)if(cinfo->btype==BT_PICASSO){/* now first reset HDR access counter */-dummy=RGen(cinfo,VGA_PEL_IW);+RGen(cinfo,VGA_PEL_IW);udelay(200);/* and at the end, restore the mask value */
From: Lee Jones <hidden> Date: 2021-01-13 14:52:48
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’:
drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable]
Cc: daniel.mantione@freepascal.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/mach64_ct.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
@@ -402,7 +402,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)structatyfb_par*par=(structatyfb_par*)info->par;u8mpost_div,xpost_div,sclk_post_div_real;u32q,memcntl,trp;-u32dsp_config,dsp_on_off,vga_dsp_config,vga_dsp_on_off;+u32dsp_config;#ifdef DEBUGintpllmclk,pllsclk;#endif
@@ -488,25 +488,10 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)/* Allow BIOS to override */dsp_config=aty_ld_le32(DSP_CONFIG,par);-dsp_on_off=aty_ld_le32(DSP_ON_OFF,par);-vga_dsp_config=aty_ld_le32(VGA_DSP_CONFIG,par);-vga_dsp_on_off=aty_ld_le32(VGA_DSP_ON_OFF,par);if(dsp_config)pll->ct.dsp_loop_latency=(dsp_config&DSP_LOOP_LATENCY)>>16;-#if 0-FIXME:isitrelevantforus?-if((!dsp_on_off&&!M64_HAS(RESET_3D))||-((dsp_on_off==vga_dsp_on_off)&&-(!dsp_config||!((dsp_config^vga_dsp_config)&DSP_XCLKS_PER_QW)))){-vga_dsp_on_off&=VGA_DSP_OFF;-vga_dsp_config&=VGA_DSP_XCLKS_PER_QW;-if(ATIDivide(vga_dsp_on_off,vga_dsp_config,5,1)>24)-pll->ct.fifo_size=32;-else-pll->ct.fifo_size=24;-}-#endif+/* Exit if the user does not want us to tamper with the clockratesofherchip.*/if(par->mclk_per==0){
From: Lee Jones <hidden> Date: 2021-01-13 14:52:49
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/mx3fb.c:738: warning: Function parameter or member 'fbi' not described in 'mx3fb_set_fix'
drivers/video/fbdev/mx3fb.c:738: warning: Excess function parameter 'info' description in 'mx3fb_set_fix'
drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'blank' not described in 'mx3fb_blank'
drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'fbi' not described in 'mx3fb_blank'
drivers/video/fbdev/mx3fb.c:1134: warning: Function parameter or member 'fbi' not described in 'mx3fb_pan_display'
drivers/video/fbdev/mx3fb.c:1134: warning: Excess function parameter 'info' description in 'mx3fb_pan_display'
drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'dev' not described in 'mx3fb_init_fbinfo'
drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'ops' not described in 'mx3fb_init_fbinfo'
Cc: Sam Ravnborg <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Software Engineering <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/mx3fb.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:52:49
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’:
drivers/video/fbdev/sis/init.c:3543:37: warning: variable ‘cr_data2’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sis/init.c:3542:39: warning: variable ‘VT’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sis/init.c:3541:39: warning: variable ‘HT’ set but not used [-Wunused-but-set-variable]
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sis/init.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:11
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’:
drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not used [-Wunused-but-set-variable]
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Ben Dooks <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/s3c-fb.c | 2 --
1 file changed, 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:12
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_print_regs'
drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_print_regs'
drivers/video/fbdev/cirrusfb.c:2815: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_print_regs'
drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_reg_dump'
drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_reg_dump'
drivers/video/fbdev/cirrusfb.c:2859: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_reg_dump'
Cc: Jeff Garzik <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/cirrusfb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
@@ -2800,7 +2800,8 @@ static void bestclock(long freq, int *nom, int *den, int *div)/***cirrusfb_dbg_print_regs-*@base:Ifusingnewmmio,thenewmmiobaseaddress,otherwise%NULL+*@info:framebufferinfostructure+*@regbase:Ifusingnewmmio,thenewmmiobaseaddress,otherwise%NULL*@reg_class:typeofregisterstoread:%CRT,or%SEQ**DESCRIPTION:
From: Lee Jones <hidden> Date: 2021-01-13 14:53:12
Can't declare these under the same clause as their use, since
debugging is enabled manually with an '#if {0,1}', so mark them as
__maybe_unused instead to notify the compiler that this behaviour is
expected.
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/s1d13xxxfb.c: In function ‘s1d13xxxfb_fetch_hw_state’:
drivers/video/fbdev/s1d13xxxfb.c:644:16: warning: variable ‘is_dual’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/s1d13xxxfb.c:643:11: warning: variable ‘lcd_bpp’ set but not used [-Wunused-but-set-variable]
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Cc: Thibaut VARENE <redacted>
Cc: Ben Dooks <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/s1d13xxxfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:12
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’:
drivers/video/fbdev/riva/riva_hw.c:845:23: warning: variable ‘vus_p’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:845:16: warning: variable ‘vus_n’ set but not used [-Wunused-but-set-variable]
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Jeff Garzik <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/riva/riva_hw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
@@ -924,8 +924,6 @@ static void nv10CalcArbitrationus_pipe_min=us_m_min+us_n+us_p;vus_m=mclk_loop*1000*1000/mclk_freq;/* Mclk latency in us */-vus_n=(4)*1000*1000/nvclk_freq;/* nvclk latency in us */-vus_p=0*1000*1000/pclk_freq;/* pclk latency in us */if(video_enable){crtc_drain_rate=pclk_freq*bpp/8;/* MB/s */
From: Lee Jones <hidden> Date: 2021-01-13 14:53:13
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/mx3fb.c: In function ‘sdc_disable_channel’:
drivers/video/fbdev/mx3fb.c:448:11: warning: variable ‘enabled’ set but not used [-Wunused-but-set-variable]
Cc: Sam Ravnborg <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Software Engineering <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/mx3fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:35
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant'
drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win'
drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk'
drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk'
drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg'
drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg'
drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win'
drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win'
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Ben Dooks <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/s3c-fb.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:36
'pending' is only used if FBCONDEBUG is defined.
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/core/fbcon.c: In function ‘fbcon_exit’:
drivers/video/fbdev/core/fbcon.c:3295:7: warning: variable ‘pending’ set but not used [-Wunused-but-set-variable]
Cc: carter@compsci.bristol.ac.uk
Cc: William Rucklidge <redacted>
Cc: Jes Sorensen <redacted>
Cc: Emmanuel Marty <redacted>
Cc: Jakub Jelinek <redacted>
Cc: Martin Mares <mj@ucw.cz>
Cc: Brad Douglas <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/core/fbcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:53:36
These are only used if SST_DEBUG_FUNC is set.
Declare them under the same clause as their use.
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/sstfb.c: In function ‘sst_detect_ics’:
drivers/video/fbdev/sstfb.c:934:26: warning: variable ‘n_clk1_b’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sstfb.c:934:16: warning: variable ‘n_clk0_7’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/sstfb.c:934:6: warning: variable ‘n_clk0_1’ set but not used [-Wunused-but-set-variable]
Cc: Alex Dewar <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Ghozlane Toumi <redacted>
Cc: James Simmons <redacted>
Cc: Paul Mundt <redacted>
Cc: Urs Ganse <redacted>
Cc: Helge Deller <deller@gmx.de>
Cc: Alan Cox <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/sstfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:54:03
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’:
drivers/video/fbdev/riva/riva_hw.c:849:9: warning: variable ‘pclks_2_top_fifo’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:848:43: warning: variable ‘vus_pipe’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:848:21: warning: variable ‘us_pipe’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:848:9: warning: variable ‘craw’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:846:27: warning: variable ‘vlwm’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:844:37: warning: variable ‘video_drain_rate’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:841:21: warning: variable ‘us_extra’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:840:55: warning: variable ‘vbs’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/riva/riva_hw.c:839:25: warning: variable ‘cas’ set but not used [-Wunused-but-set-variable]
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Jeff Garzik <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/riva/riva_hw.c | 26 ++++++++------------------
1 file changed, 8 insertions(+), 18 deletions(-)
@@ -924,17 +921,13 @@ static void nv10CalcArbitrationus_min_mclk_extra=min_mclk_extra*1000*1000/mclk_freq;us_n=nvclks*1000*1000/nvclk_freq;/* nvclk latency in us */us_p=pclks*1000*1000/pclk_freq;/* nvclk latency in us */-us_pipe=us_m+us_n+us_p;us_pipe_min=us_m_min+us_n+us_p;-us_extra=0;vus_m=mclk_loop*1000*1000/mclk_freq;/* Mclk latency in us */vus_n=(4)*1000*1000/nvclk_freq;/* nvclk latency in us */vus_p=0*1000*1000/pclk_freq;/* pclk latency in us */-vus_pipe=vus_m+vus_n+vus_p;if(video_enable){-video_drain_rate=pclk_freq*4;/* MB/s */crtc_drain_rate=pclk_freq*bpp/8;/* MB/s */vpagemiss=1;/* self generating page miss */
From: Lee Jones <hidden> Date: 2021-01-13 14:54:03
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/tdfxfb.c: In function ‘att_outb’:
drivers/video/fbdev/tdfxfb.c:209:16: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Hannu Mallat <redacted>
Cc: Frodo Looijaard <redacted>
Cc: Philip Edelbrock <redacted>
Cc: Ralph Metzler <redacted>
Cc: "Mark D. Studebaker" <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/tdfxfb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:54:25
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/aty/radeon_monitor.c: In function ‘radeon_probe_screens’:
drivers/video/fbdev/aty/radeon_monitor.c:491:8: warning: variable ‘mon_types’ set but not used [-Wunused-but-set-variable]
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:54:25
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'pdev' not described in 'pm2fb_probe'
drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'id' not described in 'pm2fb_probe'
drivers/video/fbdev/pm2fb.c:1721: warning: Function parameter or member 'pdev' not described in 'pm2fb_remove'
drivers/video/fbdev/pm2fb.c:1765: warning: Function parameter or member 'options' not described in 'pm2fb_setup'
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jim Hague <redacted>
Cc: Ilario Nardinocchi <redacted>
Cc: Jakub Jelinek <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/pm2fb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 14:55:05
Fixes the following W=1 kernel build warning(s):
drivers/video/of_videomode.c:32: warning: Function parameter or member 'np' not described in 'of_get_videomode'
drivers/video/of_videomode.c:32: warning: Function parameter or member 'vm' not described in 'of_get_videomode'
drivers/video/of_videomode.c:32: warning: Function parameter or member 'index' not described in 'of_get_videomode'
Cc: Steffen Trumtrar <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/of_videomode.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Hi,
If I remember well, the removed lines have to do with the VGA/accelerator mode of the chip. The current driver always runs the chip in accelerator mode. Suppose you would want to support high resolution hardware text modes with the driver (fbdev bpp=0), then you would need to switch the chip into VGA mode mode and then the removed lines become relevant.
I did some experiments with this when I was working on the driver, but because the documentation was silent about the behaviour of extended CRTC registers in VGA mode, I failed to make hardware text modes to work properly.
The #if 0 was there so code was already there in case me or someone else would pick it up again.
Best regards,
Daniël Mantione
Op Wed, 13 Jan 2021, schreef Lee Jones:
quoted hunk
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’:
drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable]
Cc: daniel.mantione@freepascal.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/mach64_ct.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 15:45:49
On Wed, 13 Jan 2021, Daniël Mantione wrote:
Hi,
If I remember well, the removed lines have to do with the VGA/accelerator
mode of the chip. The current driver always runs the chip in accelerator
mode. Suppose you would want to support high resolution hardware text modes
with the driver (fbdev bpp=0), then you would need to switch the chip into
VGA mode mode and then the removed lines become relevant.
I did some experiments with this when I was working on the driver, but
because the documentation was silent about the behaviour of extended CRTC
registers in VGA mode, I failed to make hardware text modes to work
properly.
The #if 0 was there so code was already there in case me or someone else
would pick it up again.
This code has been commented out for *at least* 16 years.
Probably time to let it go. :)
Best regards,
Daniël Mantione
Op Wed, 13 Jan 2021, schreef Lee Jones:
quoted
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’:
drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable]
drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable]
Cc: daniel.mantione@freepascal.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/aty/mach64_ct.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
From: Sam Ravnborg <hidden> Date: 2021-01-13 19:02:35
Hi Lee,
On Wed, Jan 13, 2021 at 02:49:38PM +0000, Lee Jones wrote:
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This patch-set clears all of the W=1 warnings currently residing
in drivers/video.
I am sorry to say that I expect most of your nice patches to clash
with patches that is already present in drm-misc-next.
drivers/video/ are warning free with W=1 in drm-misc-next today.
I do not know why drm-misc-next is not yet pullled into linux-next.
Sam
From: Jingoo Han <jingoohan1@gmail.com> Date: 2021-01-13 20:09:02
On 1/13/21, 9:50 AM, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant'
drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win'
drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk'
drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk'
drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg'
drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg'
drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win'
drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win'
Cc: Jingoo Han <jingoohan1@gmail.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Thank you.
Cc: Ben Dooks <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/s3c-fb.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
From: Jingoo Han <jingoohan1@gmail.com> Date: 2021-01-13 20:10:45
On 1/13/21, 9:50 AM, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’:
drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not used [-Wunused-but-set-variable]
Cc: Jingoo Han <jingoohan1@gmail.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
Cc: Ben Dooks <redacted>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <redacted>
---
drivers/video/fbdev/s3c-fb.c | 2 --
1 file changed, 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-01-13 20:26:48
On Wed, 13 Jan 2021, Sam Ravnborg wrote:
Hi Lee,
On Wed, Jan 13, 2021 at 02:49:38PM +0000, Lee Jones wrote:
quoted
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This patch-set clears all of the W=1 warnings currently residing
in drivers/video.
I am sorry to say that I expect most of your nice patches to clash
with patches that is already present in drm-misc-next.
drivers/video/ are warning free with W=1 in drm-misc-next today.
I do not know why drm-misc-next is not yet pullled into linux-next.
Well that kinda sucks. What are the chances of that?
Most of my patches fix issues that have been there for years!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Jani Nikula <jani.nikula@linux.intel.com> Date: 2021-01-14 09:05:56
On Wed, 13 Jan 2021, Lee Jones [off-list ref] wrote:
On Wed, 13 Jan 2021, Sam Ravnborg wrote:
quoted
Hi Lee,
On Wed, Jan 13, 2021 at 02:49:38PM +0000, Lee Jones wrote:
quoted
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This patch-set clears all of the W=1 warnings currently residing
in drivers/video.
I am sorry to say that I expect most of your nice patches to clash
with patches that is already present in drm-misc-next.
drivers/video/ are warning free with W=1 in drm-misc-next today.
I do not know why drm-misc-next is not yet pullled into linux-next.
Well that kinda sucks. What are the chances of that?
Most of my patches fix issues that have been there for years!
From: Daniel Vetter <hidden> Date: 2021-01-14 09:12:19
On Thu, Jan 14, 2021 at 10:04 AM Jani Nikula
[off-list ref] wrote:
On Wed, 13 Jan 2021, Lee Jones [off-list ref] wrote:
quoted
On Wed, 13 Jan 2021, Sam Ravnborg wrote:
quoted
Hi Lee,
On Wed, Jan 13, 2021 at 02:49:38PM +0000, Lee Jones wrote:
quoted
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This patch-set clears all of the W=1 warnings currently residing
in drivers/video.
I am sorry to say that I expect most of your nice patches to clash
with patches that is already present in drm-misc-next.
drivers/video/ are warning free with W=1 in drm-misc-next today.
I do not know why drm-misc-next is not yet pullled into linux-next.
Well that kinda sucks. What are the chances of that?
Most of my patches fix issues that have been there for years!
I planned to go through them all today, let's see what's still needed.
We auto-update the for-linux-next and for-linux-next-fixes branches, and
they seem to be up-to-date [1].
It only happened last week instead of right after -rc1 due to some
confusion, but it should have been in linux-next for a few days
already.
From: Daniel Vetter <hidden> Date: 2021-01-14 09:56:00
On Thu, Jan 14, 2021 at 10:11:01AM +0100, Daniel Vetter wrote:
On Thu, Jan 14, 2021 at 10:04 AM Jani Nikula
[off-list ref] wrote:
quoted
On Wed, 13 Jan 2021, Lee Jones [off-list ref] wrote:
quoted
On Wed, 13 Jan 2021, Sam Ravnborg wrote:
quoted
Hi Lee,
On Wed, Jan 13, 2021 at 02:49:38PM +0000, Lee Jones wrote:
quoted
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This patch-set clears all of the W=1 warnings currently residing
in drivers/video.
I am sorry to say that I expect most of your nice patches to clash
with patches that is already present in drm-misc-next.
drivers/video/ are warning free with W=1 in drm-misc-next today.
I do not know why drm-misc-next is not yet pullled into linux-next.
Well that kinda sucks. What are the chances of that?
Most of my patches fix issues that have been there for years!
I planned to go through them all today, let's see what's still needed.
First bunch of patches are all not needed anymore, I think this is quicker
if you're rebasing. Unfortunate this happened :-/
-Daniel
quoted
We auto-update the for-linux-next and for-linux-next-fixes branches, and
they seem to be up-to-date [1].
It only happened last week instead of right after -rc1 due to some
confusion, but it should have been in linux-next for a few days
already.