# Re: \[PATCH v2 04/28\] video: fbdev: aty: Delete unused variable in radeon\_monitor

- From: Thomas Zimmermann \<tzimmermann@suse.de\>
- Date: 2020-11-30 08:52:03 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2020/11/9191780
- Thread: https://ratatoskr.run/linux-fbdev/2020/11/9191720/t.md

```text


Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix warning about variable that is asssigned a value but never used.
> The variable was indeed never used so delete it.
>
> Keep the call to radeon_probe_i2c_connector() as it may have
> side-effects. It is unlikely but I could not verify that is was safe to
> drop the call.
>
> Signed-off-by: Sam Ravnborg <redacted>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: <redacted>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c
> index 9966c58aa26c..df55e23b7a5a 100644
> --- a/drivers/video/fbdev/aty/radeon_monitor.c
> +++ b/drivers/video/fbdev/aty/radeon_monitor.c
> @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo,
>   #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C)
>   		{
>   			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
> -			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
>   			int i;
>   
>   			for (i = 0; i < 4; i++)
> -				mon_types[i] = radeon_probe_i2c_connector(rinfo,
> -									  i+1, &EDIDs[i]);
> +				radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]);
>   		}
>   #endif /* DEBUG */
>   		/*
>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

```

## Attachments

- [OpenPGP\_signature](https://ratatoskr.run/linux-fbdev/2020/11/9191780/attachment/0) (application/pgp-signature, 840 bytes)
