# \[PATCH v2 12/28\] video: fbdev: tdfx: Fix set but not used warning in att\_outb()

- From: Sam Ravnborg \<hidden\>
- Date: 2020-11-28 22:42:15 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2020/11/9191734
- Thread: https://ratatoskr.run/linux-fbdev/2020/11/9191720/t.md

```text
The tmp variable were assigned but the result was never used,
so delete the tmp variable.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <redacted>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <redacted>
Cc: Jani Nikula <redacted>
Cc: Daniel Vetter <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <redacted>
---
 drivers/video/fbdev/tdfxfb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index f056d80f6359..67e37a62b07c 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
 
 static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
 {
-	unsigned char tmp;
-
-	tmp = vga_inb(par, IS1_R);
+	vga_inb(par, IS1_R);
 	vga_outb(par, ATT_IW, idx);
 	vga_outb(par, ATT_IW, val);
 }
-- 
2.27.0

```
