# \[PATCH v1 21/28\] video: fbdev: tmiofb: Fix W=1 warnings

- From: Sam Ravnborg \<hidden\>
- Date: 2020-11-27 20:00:23 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2020/11/9191703
- Thread: https://ratatoskr.run/linux-fbdev/2020/11/9191674/t.md

```text
Fix W=1 warnings by avoiding local variables and use direct references.

Signed-off-by: Sam Ravnborg <redacted>
Cc: Daniel Vetter <redacted>
Cc: Sam Ravnborg <redacted>
Cc: Jani Nikula <redacted>
---
 drivers/video/fbdev/tmiofb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/tmiofb.c b/drivers/video/fbdev/tmiofb.c
index 50111966c981..b70faa3850f2 100644
--- a/drivers/video/fbdev/tmiofb.c
+++ b/drivers/video/fbdev/tmiofb.c
@@ -802,10 +802,8 @@ static int tmiofb_remove(struct platform_device *dev)
 	const struct mfd_cell *cell = mfd_get_cell(dev);
 	struct fb_info *info = platform_get_drvdata(dev);
 	int irq = platform_get_irq(dev, 0);
-	struct tmiofb_par *par;
 
 	if (info) {
-		par = info->par;
 		unregister_framebuffer(info);
 
 		tmiofb_hw_stop(dev);
@@ -816,8 +814,8 @@ static int tmiofb_remove(struct platform_device *dev)
 		free_irq(irq, info);
 
 		iounmap(info->screen_base);
-		iounmap(par->lcr);
-		iounmap(par->ccr);
+		iounmap(((struct tmiofb_par *)info->par)->lcr);
+		iounmap(((struct tmiofb_par *)info->par)->ccr);
 
 		framebuffer_release(info);
 	}
-- 
2.27.0

```
