# \[PATCH\] video: fbdev: remove set but not used 'ulCoreClock' - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - Status: LANDED (28657c307160 · 2020-09-08 11:33) - Landed in mainline as 28657c307160 on 2020-09-08. - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2020/08/6085017/t ## \[PATCH\] video: fbdev: remove set but not used 'ulCoreClock' - From: Jason Yan \ - Date: 2020-08-27 13:28:10 - Message: https://ratatoskr.run/linux-fbdev/2020/08/6085017.md ```text This addresses the following gcc warning with "make W=1": drivers/video/fbdev/kyro/STG4000InitDevice.c: In function ‘SetCoreClockPLL’: drivers/video/fbdev/kyro/STG4000InitDevice.c:247:6: warning: variable ‘ulCoreClock’ set but not used [-Wunused-but-set-variable] // yanaijie fixed 247 | u32 ulCoreClock; | ^~~~~~~~~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/kyro/STG4000InitDevice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c index 1d3f2080aa6f..edaeec2d9590 100644 --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c @@ -244,7 +244,6 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev) { u32 F, R, P; u16 core_pll = 0, sub; - u32 ulCoreClock; u32 tmp; u32 ulChipSpeed; @@ -282,7 +281,7 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev) if (ulChipSpeed = 0) return -EINVAL; - ulCoreClock = ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P); + ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P); core_pll |= ((P) | ((F - 2) << 2) | ((R - 2) << 11)); -- 2.25.4 ``` ## Re: \[PATCH\] video: fbdev: remove set but not used 'ulCoreClock' - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-09-08 12:42:08 - Message: https://ratatoskr.run/linux-fbdev/2020/09/6097405.md ```text On 8/27/20 3:00 PM, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/video/fbdev/kyro/STG4000InitDevice.c: In function > ‘SetCoreClockPLL’: > drivers/video/fbdev/kyro/STG4000InitDevice.c:247:6: warning: variable > ‘ulCoreClock’ set but not used [-Wunused-but-set-variable] // yanaijie > fixed > 247 | u32 ulCoreClock; > | ^~~~~~~~~~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/kyro/STG4000InitDevice.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c > index 1d3f2080aa6f..edaeec2d9590 100644 > --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c > +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c > @@ -244,7 +244,6 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev) > { > u32 F, R, P; > u16 core_pll = 0, sub; > - u32 ulCoreClock; > u32 tmp; > u32 ulChipSpeed; > > @@ -282,7 +281,7 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev) > if (ulChipSpeed = 0) > return -EINVAL; > > - ulCoreClock = ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P); > + ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P); > > core_pll |= ((P) | ((F - 2) << 2) | ((R - 2) << 11)); > ```