# Re: \[PATCH\] fbdev: geocode: Add the missed pci\_disable\_device() in gx1fb\_map\_video\_memory()

- From: Markus Elfring \<hidden\>
- Date: 2020-06-03 16:49:24 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2020/06/5988562
- Thread: https://ratatoskr.run/dri-devel/2020/06/5988562/t.md

```text
> Add the missed function call to fix the bug.

…
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -208,29 +208,44 @@  static int gx1fb_map_video_memory(struct fb_info *info, struct pci_dev *dev)
…
>  	return 0;
> +
> +err:
> +	pci_disable_device(dev);
> +	return ret;
>  }
…

I suggest to use more descriptive labels so that the exception handling
can be improved accordingly.

 	return 0;
+
+e_nomem:
+	ret = -ENOMEM;
+disable_device:
+	pci_disable_device(dev);
+	return ret;
 }


Regards,
Markus
```