# \[PATCH v3\] video: fbdev: ssd1307fb: Added support to Column offset - Subsystems: FRAMEBUFFER LAYER, DRM DRIVERS, DRM DRIVERS AND MISC GPU PATCHES, OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, THE REST - Maintainers: Helge Deller, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2020/05/5964431/t ## \[PATCH v3\] video: fbdev: ssd1307fb: Added support to Column offset - From: Rodrigo Alencar \ - Date: 2020-05-13 18:48:36 - Message: https://ratatoskr.run/linux-fbdev/2020/05/5964431.md ```text From: Rodrigo Rolim Mendes de Alencar This patch provides support for displays like VGM128064B0W10, which requires a column offset of 2, i.e., its segments starts in SEG2 and ends in SEG129. Signed-off-by: Rodrigo Alencar --- Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + drivers/video/fbdev/ssd1307fb.c | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt index 27333b9551b3..2dcb6d12d137 100644 --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt @@ -19,6 +19,7 @@ Optional properties: - vbat-supply: The supply for VBAT - solomon,segment-no-remap: Display needs normal (non-inverted) data column to segment mapping + - solomon,col-offset: Offset of columns (COL/SEG) that the screen is mapped to. - solomon,com-seq: Display uses sequential COM pin configuration - solomon,com-lrremap: Display uses left-right COM pin remap - solomon,com-invdir: Display uses inverted COM pin scan direction diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 8e06ba912d60..102f941104c0 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -74,6 +74,7 @@ struct ssd1307fb_par { struct fb_info *info; u8 lookup_table[4]; u32 page_offset; + u32 col_offset; u32 prechargep1; u32 prechargep2; struct pwm_device *pwm; @@ -458,11 +459,11 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, 0x0); + ret = ssd1307fb_write_cmd(par->client, par->col_offset); if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, par->width - 1); + ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1); if (ret < 0) return ret; @@ -626,6 +627,9 @@ static int ssd1307fb_probe(struct i2c_client *client) if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset)) par->page_offset = 1; + if (device_property_read_u32(dev, "solomon,col-offset", &par->col_offset)) + par->col_offset = 0; + if (device_property_read_u32(dev, "solomon,com-offset", &par->com_offset)) par->com_offset = 0; -- 2.23.0.rc1 ``` ## Re: \[PATCH v3\] video: fbdev: ssd1307fb: Added support to Column offset - From: Rob Herring \ - Date: 2020-05-28 15:03:03 - Message: https://ratatoskr.run/linux-fbdev/2020/05/5982074.md ```text On Wed, 13 May 2020 15:48:11 -0300, Rodrigo Alencar wrote: > From: Rodrigo Rolim Mendes de Alencar > > This patch provides support for displays like VGM128064B0W10, > which requires a column offset of 2, i.e., its segments starts > in SEG2 and ends in SEG129. > > Signed-off-by: Rodrigo Alencar > --- > Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + > drivers/video/fbdev/ssd1307fb.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > Acked-by: Rob Herring ``` ## Re: \[PATCH v3\] video: fbdev: ssd1307fb: Added support to Column offset - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-07-10 14:23:20 - Message: https://ratatoskr.run/linux-fbdev/2020/07/6032032.md ```text [ added dri-devel ML to Cc: ] Hi, Sorry for the delay. On 5/13/20 8:48 PM, Rodrigo Alencar wrote: > From: Rodrigo Rolim Mendes de Alencar > > This patch provides support for displays like VGM128064B0W10, > which requires a column offset of 2, i.e., its segments starts > in SEG2 and ends in SEG129. > > Signed-off-by: Rodrigo Alencar Please resend with "From:" & "Signed-off-by:" tags fixed to match so I can merge the patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + > drivers/video/fbdev/ssd1307fb.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt > index 27333b9551b3..2dcb6d12d137 100644 > --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt > +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt > @@ -19,6 +19,7 @@ Optional properties: > - vbat-supply: The supply for VBAT > - solomon,segment-no-remap: Display needs normal (non-inverted) data column > to segment mapping > + - solomon,col-offset: Offset of columns (COL/SEG) that the screen is mapped to. > - solomon,com-seq: Display uses sequential COM pin configuration > - solomon,com-lrremap: Display uses left-right COM pin remap > - solomon,com-invdir: Display uses inverted COM pin scan direction > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 8e06ba912d60..102f941104c0 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -74,6 +74,7 @@ struct ssd1307fb_par { > struct fb_info *info; > u8 lookup_table[4]; > u32 page_offset; > + u32 col_offset; > u32 prechargep1; > u32 prechargep2; > struct pwm_device *pwm; > @@ -458,11 +459,11 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) > if (ret < 0) > return ret; > > - ret = ssd1307fb_write_cmd(par->client, 0x0); > + ret = ssd1307fb_write_cmd(par->client, par->col_offset); > if (ret < 0) > return ret; > > - ret = ssd1307fb_write_cmd(par->client, par->width - 1); > + ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1); > if (ret < 0) > return ret; > > @@ -626,6 +627,9 @@ static int ssd1307fb_probe(struct i2c_client *client) > if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset)) > par->page_offset = 1; > > + if (device_property_read_u32(dev, "solomon,col-offset", &par->col_offset)) > + par->col_offset = 0; > + > if (device_property_read_u32(dev, "solomon,com-offset", &par->com_offset)) > par->com_offset = 0; > > ```