# \[PATCH v1\] console: fix an issue about ioremap leak.

- From: Dejin Zheng \<hidden\>
- Date: 2020-04-22 15:53:39 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2020/04/5938495
- Thread: https://ratatoskr.run/dri-devel/2020/04/5938495/t.md

```text
if do_take_over_console() return an error in the newport_probe(),
due to the io virtual address is not released, it will cause a leak.

Fixes: e84de0c6190503 ("MIPS: GIO bus support for SGI IP22/28")
CC: Andy Shevchenko <redacted>
Signed-off-by: Dejin Zheng <redacted>
---
 drivers/video/console/newport_con.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index 00dddf6e08b0..6bfc8e3ffd4a 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -720,6 +720,9 @@ static int newport_probe(struct gio_device *dev,
 	console_lock();
 	err = do_take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1);
 	console_unlock();
+
+	if (err)
+		iounmap((void *)npregs);
 	return err;
 }
 
-- 
2.25.0
```