# \[PATCH 0/1\] video: convert to use new I2C API - Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, THE REST - Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds - Series: 1 patch touching 1 file, +2/-2 - List: linux-fbdev - 6 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2020/03/5908905/t ## \[PATCH 0/1\] video: convert to use new I2C API - From: Wolfram Sang \ - Date: 2020-03-26 21:10:17 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5908905.md ```text We are deprecating calls which return NULL in favor of new variants which return an ERR_PTR. Only build tested. Wolfram Sang (1): video: backlight: tosa_lcd: convert to use i2c_new_client_device() drivers/video/backlight/tosa_lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 ``` ## \[PATCH 1/1\] video: backlight: tosa\_lcd: convert to use i2c\_new\_client\_device() - From: Wolfram Sang \ - Date: 2020-03-26 21:10:20 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5908906.md ```text Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/video/backlight/tosa_lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c index e8ab583e5098..113116d3585c 100644 --- a/drivers/video/backlight/tosa_lcd.c +++ b/drivers/video/backlight/tosa_lcd.c @@ -107,7 +107,7 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data) /* TG LCD GVSS */ tosa_tg_send(spi, TG_PINICTL, 0x0); - if (!data->i2c) { + if (IS_ERR_OR_NULL(data->i2c)) { /* * after the pannel is powered up the first time, * we can access the i2c bus so probe for the DAC @@ -119,7 +119,7 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data) .addr = DAC_BASE, .platform_data = data->spi, }; - data->i2c = i2c_new_device(adap, &info); + data->i2c = i2c_new_client_device(adap, &info); } } -- 2.20.1 ``` ## Re: \[PATCH 1/1\] video: backlight: tosa\_lcd: convert to use i2c\_new\_client\_device() - From: Daniel Thompson \ - Date: 2020-04-15 10:40:06 - Message: https://ratatoskr.run/linux-fbdev/2020/04/5928057.md ```text On Thu, Mar 26, 2020 at 10:09:59PM +0100, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/tosa_lcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c > index e8ab583e5098..113116d3585c 100644 > --- a/drivers/video/backlight/tosa_lcd.c > +++ b/drivers/video/backlight/tosa_lcd.c > @@ -107,7 +107,7 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data) > /* TG LCD GVSS */ > tosa_tg_send(spi, TG_PINICTL, 0x0); > > - if (!data->i2c) { > + if (IS_ERR_OR_NULL(data->i2c)) { > /* > * after the pannel is powered up the first time, > * we can access the i2c bus so probe for the DAC > @@ -119,7 +119,7 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data) > .addr = DAC_BASE, > .platform_data = data->spi, > }; > - data->i2c = i2c_new_device(adap, &info); > + data->i2c = i2c_new_client_device(adap, &info); > } > } > > -- > 2.20.1 > ``` ## Re: \[PATCH 1/1\] video: backlight: tosa\_lcd: convert to use i2c\_new\_client\_device() - From: Lee Jones \ - Date: 2020-04-17 10:13:49 - Message: https://ratatoskr.run/linux-fbdev/2020/04/5931989.md ```text On Thu, 26 Mar 2020, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang > --- > drivers/video/backlight/tosa_lcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ``` ## Re: \[PATCH 1/1\] video: backlight: tosa\_lcd: convert to use i2c\_new\_client\_device() - From: Wolfram Sang \ - Date: 2020-05-12 16:25:50 - Message: https://ratatoskr.run/linux-fbdev/2020/05/5962600.md ```text On Fri, Apr 17, 2020 at 11:14:46AM +0100, Lee Jones wrote: > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > Move away from the deprecated API and return the shiny new ERRPTR where > > useful. > > > > Signed-off-by: Wolfram Sang > > --- > > drivers/video/backlight/tosa_lcd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied, thanks. Thanks! I don't see it in -next, though? ``` ## Re: \[PATCH 1/1\] video: backlight: tosa\_lcd: convert to use i2c\_new\_client\_device() - From: Lee Jones \ - Date: 2020-05-13 08:01:05 - Message: https://ratatoskr.run/linux-fbdev/2020/05/5963342.md ```text On Tue, 12 May 2020, Wolfram Sang wrote: > On Fri, Apr 17, 2020 at 11:14:46AM +0100, Lee Jones wrote: > > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > > > Move away from the deprecated API and return the shiny new ERRPTR where > > > useful. > > > > > > Signed-off-by: Wolfram Sang > > > --- > > > drivers/video/backlight/tosa_lcd.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Applied, thanks. > > Thanks! I don't see it in -next, though? Just pushed. Should be there soon. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ```