[PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

Subsystems: simplefb fb driver, the rest

STALE2409d

5 messages, 3 authors, 2020-03-02 · open the first message on its own page

[PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-02-04 16:21:14

Replace with appropriate types.h.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/platform_data/simplefb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
index 4f733a411d18..ca8337695c2a 100644
--- a/include/linux/platform_data/simplefb.h
+++ b/include/linux/platform_data/simplefb.h

@@ -10,7 +10,7 @@
 
 #include <drm/drm_fourcc.h>
 #include <linux/fb.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 /* format array, use it to initialize a "struct simplefb_format" array */
 #define SIMPLEFB_FORMATS \

-- 
2.24.1

Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-02-14 14:25:50

On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:

Replace with appropriate types.h.

Hans, any comment on this?

quoted hunk

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/platform_data/simplefb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
index 4f733a411d18..ca8337695c2a 100644
--- a/include/linux/platform_data/simplefb.h
+++ b/include/linux/platform_data/simplefb.h

@@ -10,7 +10,7 @@
 
 #include <drm/drm_fourcc.h>
 #include <linux/fb.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 /* format array, use it to initialize a "struct simplefb_format" array */
 #define SIMPLEFB_FORMATS \

-- 
2.24.1

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

From: Hans de Goede <hidden>
Date: 2020-02-14 15:21:57

Hi,

On 2/14/20 3:25 PM, Andy Shevchenko wrote:

On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:

quoted

Replace with appropriate types.h.

Hans, any comment on this?

Not really, I've not touched that code in a while.

But I see I'm still listed as the maintainer, the change looks sensible
to me, so:

Acked-by: Hans de Goede <redacted>

Regards,

Hans

quoted

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
  include/linux/platform_data/simplefb.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
index 4f733a411d18..ca8337695c2a 100644
--- a/include/linux/platform_data/simplefb.h
+++ b/include/linux/platform_data/simplefb.h

@@ -10,7 +10,7 @@
  
  #include <drm/drm_fourcc.h>
  #include <linux/fb.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
  
  /* format array, use it to initialize a "struct simplefb_format" array */
  #define SIMPLEFB_FORMATS \

-- 
2.24.1

Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-02-14 18:08:21

On Fri, Feb 14, 2020 at 04:21:57PM +0100, Hans de Goede wrote:

On 2/14/20 3:25 PM, Andy Shevchenko wrote:

quoted

On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:

quoted

Replace with appropriate types.h.

Hans, any comment on this?

Not really, I've not touched that code in a while.

But I see I'm still listed as the maintainer, the change looks sensible
to me, so:

Acked-by: Hans de Goede <redacted>

Thanks!
Seems get_maintainer does not list Bart, so, Cc him here.

quoted

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
  include/linux/platform_data/simplefb.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
index 4f733a411d18..ca8337695c2a 100644
--- a/include/linux/platform_data/simplefb.h
+++ b/include/linux/platform_data/simplefb.h

@@ -10,7 +10,7 @@
  #include <drm/drm_fourcc.h>
  #include <linux/fb.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
  /* format array, use it to initialize a "struct simplefb_format" array */
  #define SIMPLEFB_FORMATS \

-- 
2.24.1

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] fbdev: simplefb: Platform data shan't include kernel.h

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2020-03-02 15:42:49

On 2/14/20 7:08 PM, Andy Shevchenko wrote:

On Fri, Feb 14, 2020 at 04:21:57PM +0100, Hans de Goede wrote:

quoted

On 2/14/20 3:25 PM, Andy Shevchenko wrote:

quoted

On Tue, Feb 04, 2020 at 06:21:14PM +0200, Andy Shevchenko wrote:

quoted

Replace with appropriate types.h.

Hans, any comment on this?

Not really, I've not touched that code in a while.

But I see I'm still listed as the maintainer, the change looks sensible
to me, so:

Acked-by: Hans de Goede <redacted>

Thanks!
Seems get_maintainer does not list Bart, so, Cc him here.

quoted

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Patch queued for v5.7, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

quoted

---
  include/linux/platform_data/simplefb.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h
index 4f733a411d18..ca8337695c2a 100644
--- a/include/linux/platform_data/simplefb.h
+++ b/include/linux/platform_data/simplefb.h

@@ -10,7 +10,7 @@
  #include <drm/drm_fourcc.h>
  #include <linux/fb.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
  /* format array, use it to initialize a "struct simplefb_format" array */
  #define SIMPLEFB_FORMATS \

-- 
2.24.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help