Signed-off-by: Rich Felker <dalias@libc.org>
--
I've had this lying around a while and figure I should send it
upsteam; it's needed to support the onboard video on my Spectre-free
Atom S1260 server board.
---
drivers/video/fbdev/matrox/matroxfb_base.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
@@ -1376,6 +1376,12 @@ static struct video_board vbG200 = {.accelID=FB_ACCEL_MATROX_MGAG200,.lowlevel=&matrox_G100};+staticstructvideo_boardvbG200eW={+.maxvram=0x800000,+.maxdisplayable=0x800000,+.accelID=FB_ACCEL_MATROX_MGAG200,+.lowlevel=&matrox_G100+};/* from doc it looks like that accelerator can draw only to low 16MB :-( Direct accesses & displaying are OK forwhole32MB*/staticstructvideo_boardvbG400={
Hi Greg,
On Sun, Jan 26, 2020 at 8:44 AM Greg Kroah-Hartman
[off-list ref] wrote:
On Sat, Jan 25, 2020 at 02:55:06PM -0500, Rich Felker wrote:
quoted
Signed-off-by: Rich Felker <dalias@libc.org>
--
I know I don't accept patches without any changelog text, don't know
about other subsystem maintainers...
FTR, I do, iff the one-line summary says everything that needs to be said.
What's the point in writing a full paragraph like:
Currently the foo driver does not support the bar device.
As users may want to use the bar device, it makes perfect sense
to add support for the bar device to the foo driver.
Hence add support for the bar device to the foo driver.
if this doesn't add any value on top of the one-line summary?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Ville Syrjälä <hidden> Date: 2020-01-27 11:59:32
On Mon, Jan 27, 2020 at 11:40:24AM +0100, Geert Uytterhoeven wrote:
Hi Greg,
On Sun, Jan 26, 2020 at 8:44 AM Greg Kroah-Hartman
[off-list ref] wrote:
quoted
On Sat, Jan 25, 2020 at 02:55:06PM -0500, Rich Felker wrote:
quoted
Signed-off-by: Rich Felker <dalias@libc.org>
--
I know I don't accept patches without any changelog text, don't know
about other subsystem maintainers...
FTR, I do, iff the one-line summary says everything that needs to be said.
What's the point in writing a full paragraph like:
Currently the foo driver does not support the bar device.
As users may want to use the bar device, it makes perfect sense
to add support for the bar device to the foo driver.
Hence add support for the bar device to the foo driver.
if this doesn't add any value on top of the one-line summary?
At least it allows one to reply to *something*. If there's just a
subject line you have zero quoted context for the reply apart from
the patch itself. So rather confusing if you want to comment on
the overall thing rather than on any specific changes in the diff.
The other bad commit message style I dislike is the:
"Subject: Do something...
...because whatever."
As if the subject was a part of the first sentence of the commit
message. Often makes replies even more confusing since now you
have just a part of the sentece quoted.
I do understand why new people make this mistake though; There
should probably be a more explicit indication that the first
line is the subject when editing the commit message.
--
Ville Syrjälä
Intel
From: Thomas Zimmermann <tzimmermann@suse.de> Date: 2020-01-27 07:36:16
Hi
Am 25.01.20 um 20:55 schrieb Rich Felker:
Signed-off-by: Rich Felker <dalias@libc.org>
--
I've had this lying around a while and figure I should send it
upsteam; it's needed to support the onboard video on my Spectre-free
Atom S1260 server board.
This HW is supported by mgag200, which is maintained. Can't you use that?
Best regards
Thomas
@@ -1376,6 +1376,12 @@ static struct video_board vbG200 = {.accelID=FB_ACCEL_MATROX_MGAG200,.lowlevel=&matrox_G100};+staticstructvideo_boardvbG200eW={+.maxvram=0x800000,+.maxdisplayable=0x800000,+.accelID=FB_ACCEL_MATROX_MGAG200,+.lowlevel=&matrox_G100+};/* from doc it looks like that accelerator can draw only to low 16MB :-( Direct accesses & displaying are OK forwhole32MB*/staticstructvideo_boardvbG400={
On Mon, Jan 27, 2020 at 08:36:07AM +0100, Thomas Zimmermann wrote:
Hi
Am 25.01.20 um 20:55 schrieb Rich Felker:
quoted
Signed-off-by: Rich Felker <dalias@libc.org>
--
I've had this lying around a while and figure I should send it
upsteam; it's needed to support the onboard video on my Spectre-free
Atom S1260 server board.
This HW is supported by mgag200, which is maintained. Can't you use that?
Perhaps; I wasn't aware it existed. I'll give it a try. It still might
be nice to apply my patch though since the matroxfb driver works with
it and only fails to support it because of not knowing the device id.
Rich
From: Thomas Zimmermann <tzimmermann@suse.de> Date: 2020-01-29 07:20:46
Hi
Am 28.01.20 um 19:58 schrieb Rich Felker:
On Mon, Jan 27, 2020 at 08:36:07AM +0100, Thomas Zimmermann wrote:
quoted
Hi
Am 25.01.20 um 20:55 schrieb Rich Felker:
quoted
Signed-off-by: Rich Felker <dalias@libc.org>
--
I've had this lying around a while and figure I should send it
upsteam; it's needed to support the onboard video on my Spectre-free
Atom S1260 server board.
This HW is supported by mgag200, which is maintained. Can't you use that?
Perhaps; I wasn't aware it existed. I'll give it a try. It still might
be nice to apply my patch though since the matroxfb driver works with
it and only fails to support it because of not knowing the device id.
Well, I have no say about applying your patch. You can ping me however,
if mgag200 doesn't work for you.
Best regards
Thomas
Rich
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
quoted hunk
--
I've had this lying around a while and figure I should send it
upsteam; it's needed to support the onboard video on my Spectre-free
Atom S1260 server board.
---
drivers/video/fbdev/matrox/matroxfb_base.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
@@ -1376,6 +1376,12 @@ static struct video_board vbG200 = {.accelID=FB_ACCEL_MATROX_MGAG200,.lowlevel=&matrox_G100};+staticstructvideo_boardvbG200eW={+.maxvram=0x800000,+.maxdisplayable=0x800000,+.accelID=FB_ACCEL_MATROX_MGAG200,+.lowlevel=&matrox_G100+};/* from doc it looks like that accelerator can draw only to low 16MB :-( Direct accesses & displaying are OK forwhole32MB*/staticstructvideo_boardvbG400={