# \[PATCH 0/4\] cleanup patches for unused variables - Subsystems: FRAMEBUFFER LAYER, RADEON FRAMEBUFFER DISPLAY DRIVER, THE REST - Maintainers: Helge Deller, Benjamin Herrenschmidt, Linus Torvalds - Series: 4 patches touching 1 file, +4/-10 - Status: LANDED - Landed in mainline. - List: linux-fbdev - 9 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2020/01/5836845/t ## \[PATCH 0/4\] cleanup patches for unused variables - From: yu kuai \ - Date: 2020-01-19 12:18:42 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5836845.md ```text yu kuai (4): video: fbdev: remove set but not used variable 'hSyncPol' video: fbdev: remove set but not used variable 'vSyncPol' video: fbdev: remove set but not used variable 'vSyncPol' video: fbdev: remove set but not used variable 'bytpp' drivers/video/fbdev/aty/radeon_base.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.17.2 ``` ## \[PATCH 1/4\] video: fbdev: remove set but not used variable 'hSyncPol' - From: yu kuai \ - Date: 2020-01-19 12:18:31 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5836841.md ```text Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:6: warning: variable ‘hSyncPol’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 3af00e3b965e..d2e68ec580c2 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - hSyncPol, vSyncStart, vSyncEnd, vSyncPol, cSync; + vSyncStart, vSyncEnd, vSyncPol, cSync; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,7 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - hSyncPol = mode->sync & FB_SYNC_HOR_HIGH_ACT ? 0 : 1; vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; -- 2.17.2 ``` ## \[PATCH 3/4\] video: fbdev: remove set but not used variable 'vSyncPol' - From: yu kuai \ - Date: 2020-01-19 12:18:31 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5836842.md ```text Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable ‘cSync’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 0666f848bf70..7d2ee889ffcd 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - vSyncStart, vSyncEnd, cSync; + vSyncStart, vSyncEnd; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; - format = radeon_get_dstbpp(depth); bytpp = mode->bits_per_pixel >> 3; -- 2.17.2 ``` ## \[PATCH 2/4\] video: fbdev: remove set but not used variable 'vSyncPol' - From: yu kuai \ - Date: 2020-01-19 12:18:32 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5836843.md ```text Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:38: warning: variable ‘vSyncPol’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index d2e68ec580c2..0666f848bf70 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - vSyncStart, vSyncEnd, vSyncPol, cSync; + vSyncStart, vSyncEnd, cSync; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; format = radeon_get_dstbpp(depth); -- 2.17.2 ``` ## \[PATCH 4/4\] video: fbdev: remove set but not used variable 'bytpp' - From: yu kuai \ - Date: 2020-01-19 12:18:37 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5836844.md ```text Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1660:32: warning: variable ‘bytpp’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 7d2ee889ffcd..22b3ee4f2ffa 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info) int i, freq; int format = 0; int nopllcalc = 0; - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid; + int hsync_start, hsync_fudge, hsync_wid, vsync_wid; int primary_mon = PRIMARY_MONITOR(rinfo); int depth = var_to_depth(mode); int use_rmx = 0; @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info) vsync_wid = 0x1f; format = radeon_get_dstbpp(depth); - bytpp = mode->bits_per_pixel >> 3; if ((primary_mon = MT_DFP) || (primary_mon = MT_LCD)) hsync_fudge = hsync_fudge_fp[format-1]; -- 2.17.2 ``` ## Re: \[PATCH 1/4\] video: fbdev: remove set but not used variable 'hSyncPol' - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-03-02 15:42:21 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5881350.md ```text On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:6: warning: variable > ‘hSyncPol’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 3af00e3b965e..d2e68ec580c2 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) > struct fb_var_screeninfo *mode = &info->var; > struct radeon_regs *newmode; > int hTotal, vTotal, hSyncStart, hSyncEnd, > - hSyncPol, vSyncStart, vSyncEnd, vSyncPol, cSync; > + vSyncStart, vSyncEnd, vSyncPol, cSync; > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; > u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; > @@ -1730,7 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) > else if (vsync_wid > 0x1f) /* max */ > vsync_wid = 0x1f; > > - hSyncPol = mode->sync & FB_SYNC_HOR_HIGH_ACT ? 0 : 1; > vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; > > cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; > ``` ## Re: \[PATCH 2/4\] video: fbdev: remove set but not used variable 'vSyncPol' - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-03-02 15:42:25 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5881351.md ```text On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:38: warning: variable > ‘vSyncPol’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index d2e68ec580c2..0666f848bf70 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) > struct fb_var_screeninfo *mode = &info->var; > struct radeon_regs *newmode; > int hTotal, vTotal, hSyncStart, hSyncEnd, > - vSyncStart, vSyncEnd, vSyncPol, cSync; > + vSyncStart, vSyncEnd, cSync; > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; > u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; > @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) > else if (vsync_wid > 0x1f) /* max */ > vsync_wid = 0x1f; > > - vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; > - > cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; > > format = radeon_get_dstbpp(depth); > ``` ## Re: \[PATCH 3/4\] video: fbdev: remove set but not used variable 'vSyncPol' - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-03-02 15:42:30 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5881352.md ```text On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable > ‘cSync’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 0666f848bf70..7d2ee889ffcd 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) > struct fb_var_screeninfo *mode = &info->var; > struct radeon_regs *newmode; > int hTotal, vTotal, hSyncStart, hSyncEnd, > - vSyncStart, vSyncEnd, cSync; > + vSyncStart, vSyncEnd; > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; > u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; > @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) > else if (vsync_wid > 0x1f) /* max */ > vsync_wid = 0x1f; > > - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; > - > format = radeon_get_dstbpp(depth); > bytpp = mode->bits_per_pixel >> 3; > ``` ## Re: \[PATCH 4/4\] video: fbdev: remove set but not used variable 'bytpp' - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-03-02 15:42:35 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5881353.md ```text On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1660:32: warning: > variable ‘bytpp’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 7d2ee889ffcd..22b3ee4f2ffa 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info) > int i, freq; > int format = 0; > int nopllcalc = 0; > - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid; > + int hsync_start, hsync_fudge, hsync_wid, vsync_wid; > int primary_mon = PRIMARY_MONITOR(rinfo); > int depth = var_to_depth(mode); > int use_rmx = 0; > @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info) > vsync_wid = 0x1f; > > format = radeon_get_dstbpp(depth); > - bytpp = mode->bits_per_pixel >> 3; > > if ((primary_mon = MT_DFP) || (primary_mon = MT_LCD)) > hsync_fudge = hsync_fudge_fp[format-1]; > ```