# \[PATCH -next\] video: fbdev: pxa168fb: remove unnecessary platform\_get\_irq

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- Status: LANDED (3e26e0c47e5c · 2020-03-02 15:31)
- Landed in mainline as 3e26e0c47e5c on 2020-03-02.
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2020/01/5835418/t

## \[PATCH -next\] video: fbdev: pxa168fb: remove unnecessary platform\_get\_irq

- From: YueHaibing \<hidden\>
- Date: 2020-01-17 03:23:01 
- Message: https://ratatoskr.run/linux-fbdev/2020/01/5835418.md

```text
commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions")
left behind this, it can be removed.

Signed-off-by: YueHaibing <redacted>
---
 drivers/video/fbdev/pxa168fb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 706c6943..aef8a30 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -779,7 +779,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
 {
 	struct pxa168fb_info *fbi = platform_get_drvdata(pdev);
 	struct fb_info *info;
-	int irq;
 	unsigned int data;
 
 	if (!fbi)
@@ -799,8 +798,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
 	if (info->cmap.len)
 		fb_dealloc_cmap(&info->cmap);
 
-	irq = platform_get_irq(pdev, 0);
-
 	dma_free_wc(fbi->dev, info->fix.smem_len,
 		    info->screen_base, info->fix.smem_start);
 
-- 
2.7.4
```

## Re: \[PATCH -next\] video: fbdev: pxa168fb: remove unnecessary platform\_get\_irq

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2020-03-02 15:41:38 
- Message: https://ratatoskr.run/linux-fbdev/2020/03/5881340.md

```text

On 1/17/20 4:22 AM, YueHaibing wrote:
> commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions")
> left behind this, it can be removed.
> 
> Signed-off-by: YueHaibing <redacted>

Patch queued for v5.7, thanks.
 
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/pxa168fb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 706c6943..aef8a30 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -779,7 +779,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
>  {
>  	struct pxa168fb_info *fbi = platform_get_drvdata(pdev);
>  	struct fb_info *info;
> -	int irq;
>  	unsigned int data;
>  
>  	if (!fbi)
> @@ -799,8 +798,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
>  	if (info->cmap.len)
>  		fb_dealloc_cmap(&info->cmap);
>  
> -	irq = platform_get_irq(pdev, 0);
> -
>  	dma_free_wc(fbi->dev, info->fix.smem_len,
>  		    info->screen_base, info->fix.smem_start);
>  
```