# \[PATCH 1/2\] video: fbdev: sh\_mobile\_lcdcfb: fix sparse warnings about using incorrect types - Status: LANDED (5d30146f9439 ยท 2020-03-02 15:31) - Landed in mainline as 5d30146f9439 on 2020-03-02. - List: linux-fbdev - 3 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2020/01/5832840/t ## \[PATCH 1/2\] video: fbdev: sh\_mobile\_lcdcfb: fix sparse warnings about using incorrect types - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-01-16 14:51:19 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5832840.md ```text Use ->screen_buffer instead of ->screen_base to fix sparse warnings. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/video/fbdev/sh_mobile_lcdcfb.c =================================--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1572,7 +1572,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &sh_mobile_lcdc_overlay_ops; info->device = priv->dev; - info->screen_base = ovl->fb_mem; + info->screen_buffer = ovl->fb_mem; info->par = ovl; /* Initialize fixed screen information. Restrict pan to 2 lines steps @@ -2056,7 +2056,7 @@ sh_mobile_lcdc_channel_fb_init(struct sh info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &sh_mobile_lcdc_ops; info->device = priv->dev; - info->screen_base = ch->fb_mem; + info->screen_buffer = ch->fb_mem; info->pseudo_palette = &ch->pseudo_palette; info->par = ch; ``` ## Re: \[PATCH 1/2\] video: fbdev: sh\_mobile\_lcdcfb: fix sparse warnings about using incorrect types - From: Geert Uytterhoeven \ - Date: 2020-01-17 14:08:13 - Message: https://ratatoskr.run/linux-fbdev/2020/01/5835892.md ```text On Thu, Jan 16, 2020 at 3:51 PM Bartlomiej Zolnierkiewicz [ref] wrote: > Use ->screen_buffer instead of ->screen_base to fix sparse warnings. > > [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base > pointer") for details. ] > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ``` ## Re: \[PATCH 1/2\] video: fbdev: sh\_mobile\_lcdcfb: fix sparse warnings about using incorrect types - From: Bartlomiej Zolnierkiewicz \ - Date: 2020-03-02 15:41:44 - Message: https://ratatoskr.run/linux-fbdev/2020/03/5881341.md ```text On 1/17/20 3:08 PM, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2020 at 3:51 PM Bartlomiej Zolnierkiewicz > [ref] wrote: >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer") for details. ] >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Reviewed-by: Geert Uytterhoeven Thanks, patch queued for v5.7. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ```