[PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

STALE2397d

2 messages, 2 authors, 2020-01-07 · open the first message on its own page

[PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

From: Julia Lawall <julia.lawall@inria.fr>
Date: 2020-01-04 20:43:34

From: kbuild test robot <redacted>

Remove dev_err() messages after platform_get_irq*() failures.
Line 450 is redundant because platform_get_irq() already prints
an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
Signed-off-by: kbuild test robot <redacted>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head:   80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

 mmp_ctrl.c |    1 -
 1 file changed, 1 deletion(-)
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d

 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
 		ret = -ENOENT;
 		goto failed;
 	}

Re: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

From: Daniel Vetter <hidden>
Date: 2020-01-07 16:14:07

On Sat, Jan 04, 2020 at 09:43:31PM +0100, Julia Lawall wrote:
From: kbuild test robot <redacted>

Remove dev_err() messages after platform_get_irq*() failures.
Line 450 is redundant because platform_get_irq() already prints
an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
Signed-off-by: kbuild test robot <redacted>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Applied to drm-misc-next, thanks for your patch.
-Daniel
quoted hunk
---

tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head:   80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

 mmp_ctrl.c |    1 -
 1 file changed, 1 deletion(-)
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d

 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
 		ret = -ENOENT;
 		goto failed;
 	}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help