# \[PATCH -next\] fbdev: s3c-fb: use devm\_platform\_ioremap\_resource() to simplify code

- Subsystems: FRAMEBUFFER LAYER, SAMSUNG FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Jingoo Han, Linus Torvalds
- Status: LANDED (8d5598f13fe7 · 2020-01-03 13:27)
- Landed in mainline as 8d5598f13fe7 on 2020-01-03.
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2019/09/5708258/t

## \[PATCH -next\] fbdev: s3c-fb: use devm\_platform\_ioremap\_resource() to simplify code

- From: YueHaibing \<hidden\>
- Date: 2019-09-04 11:57:19 
- Message: https://ratatoskr.run/linux-fbdev/2019/09/5708258.md

```text
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <redacted>
Signed-off-by: YueHaibing <redacted>
---
 drivers/video/fbdev/s3c-fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index ba04d7a..43ac8d7 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(sfb->dev);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	sfb->regs = devm_ioremap_resource(dev, res);
+	sfb->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(sfb->regs)) {
 		ret = PTR_ERR(sfb->regs);
 		goto err_lcd_clk;
-- 
2.7.4
```

## Re: \[PATCH -next\] fbdev: s3c-fb: use devm\_platform\_ioremap\_resource() to simplify code

- From: Jingoo Han \<jingoohan1@gmail.com\>
- Date: 2019-09-17 19:21:39 
- Message: https://ratatoskr.run/linux-fbdev/2019/09/5719223.md

```text
DQoNCu+7v09uIDkvNC8xOSwgNzo1NyBBTSwgWXVlSGFpYmluZyB3cm90ZToNCg0KPiBVc2UgZGV2
bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKCkgdG8gc2ltcGxpZnkgdGhlIGNvZGUgYSBiaXQu
DQo+IFRoaXMgaXMgZGV0ZWN0ZWQgYnkgY29jY2luZWxsZS4NCj4NCj4gUmVwb3J0ZWQtYnk6IEh1
bGsgUm9ib3QgPGh1bGtjaUBodWF3ZWkuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBZdWVIYWliaW5n
IDx5dWVoYWliaW5nQGh1YXdlaS5jb20+DQo+DQpBY2tlZC1ieTogSmluZ29vIEhhbiA8amluZ29v
aGFuMUBnbWFpbC5jb20+DQo+DQo+IC0tLQ0KPiAgZHJpdmVycy92aWRlby9mYmRldi9zM2MtZmIu
YyB8IDMgKy0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25z
KC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3MzYy1mYi5jIGIvZHJp
dmVycy92aWRlby9mYmRldi9zM2MtZmIuYw0KPiBpbmRleCBiYTA0ZDdhLi40M2FjOGQ3IDEwMDY0
NA0KPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3MzYy1mYi5jDQo+ICsrKyBiL2RyaXZlcnMv
dmlkZW8vZmJkZXYvczNjLWZiLmMNCj4gQEAgLTE0MTEsOCArMTQxMSw3IEBAIHN0YXRpYyBpbnQg
czNjX2ZiX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ICANCj4gIAlwbV9y
dW50aW1lX2VuYWJsZShzZmItPmRldik7DQo+ICANCj4gLQlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVz
b3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOw0KPiAtCXNmYi0+cmVncyA9IGRldm1faW9y
ZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7DQo+ICsJc2ZiLT5yZWdzID0gZGV2bV9wbGF0Zm9ybV9p
b3JlbWFwX3Jlc291cmNlKHBkZXYsIDApOw0KPiAgCWlmIChJU19FUlIoc2ZiLT5yZWdzKSkgew0K
PiAgCQlyZXQgPSBQVFJfRVJSKHNmYi0+cmVncyk7DQo+ICAJCWdvdG8gZXJyX2xjZF9jbGs7DQo+
IC0tIA0KPiAyLjcuNA0KDQoNCg=
```

## Re: \[PATCH -next\] fbdev: s3c-fb: use devm\_platform\_ioremap\_resource() to simplify code

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2020-01-03 12:15:06 
- Message: https://ratatoskr.run/linux-fbdev/2020/01/5820329.md

```text

On 9/17/19 9:21 PM, Jingoo Han wrote:
> 
> 
> On 9/4/19, 7:57 AM, YueHaibing wrote:
> 
>> Use devm_platform_ioremap_resource() to simplify the code a bit.
>> This is detected by coccinelle.
>>
>> Reported-by: Hulk Robot <redacted>
>> Signed-off-by: YueHaibing <redacted>
>>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

>> ---
>>  drivers/video/fbdev/s3c-fb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
>> index ba04d7a..43ac8d7 100644
>> --- a/drivers/video/fbdev/s3c-fb.c
>> +++ b/drivers/video/fbdev/s3c-fb.c
>> @@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>>  
>>  	pm_runtime_enable(sfb->dev);
>>  
>> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -	sfb->regs = devm_ioremap_resource(dev, res);
>> +	sfb->regs = devm_platform_ioremap_resource(pdev, 0);
>>  	if (IS_ERR(sfb->regs)) {
>>  		ret = PTR_ERR(sfb->regs);
>>  		goto err_lcd_clk;
>> -- 
>> 2.7.4
```