# Re: \[PATCH v3 3/3\] fbdev: fbmem: avoid exporting fb\_center\_logo

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2019-08-27 11:35:32 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2019/08/5700114
- Thread: https://ratatoskr.run/dri-devel/2019/08/5700096/t.md

```text
Hi Peter,

On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin [ref] wrote:
> The variable is only ever used from fbcon.c which is linked into the
> same module. Therefore, the export is not needed.
>
> Signed-off-by: Peter Rosin <redacted>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

But note that the same is true for fb_class, so perhaps it can be added
(or better, removed ;-)?

Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[]
and num_registered_fb, those can go, too.

Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo()
itself?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
```