# Re: \[PATCH\] video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with \< 0

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2019-08-19 14:02:03 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2019/08/5691712
- Thread: https://ratatoskr.run/dri-devel/2019/07/5662360/t.md

```text

On 7/22/19 10:33 PM, Gustavo A. R. Silva wrote:
> There is no need to compare *var->xoffset* or *var->yoffset* with < 0
> because such variables are of type unsigned, making it impossible to
> hold a negative value.
> 
> Fix this by removing such comparisons.
> 
> Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0")
> Signed-off-by: Gustavo A. R. Silva <redacted>
Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```