# Re: \[PATCH 4/4\] video: amba-clcd: Spout an error if of\_get\_display\_timing() gives an error

- From: Linus Walleij \<hidden\>
- Date: 2019-07-23 08:27:45 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2019/07/5662851
- Thread: https://ratatoskr.run/linux-fbdev/2019/07/5662208/t.md

```text
On Mon, Jul 22, 2019 at 8:25 PM Douglas Anderson [ref] wrote:

> In the patch ("video: of: display_timing: Don't yell if no timing node
> is present") we'll stop spouting an error directly in
> of_get_display_timing() if no node is present.  Presumably amba-clcd
> should take charge of spouting its own error now.
>
> NOTE: we'll print two errors if the node was present but there were
> problems parsing the timing node (one in of_parse_display_timing() and
> this new one).  Since this is a fatal error for the driver's probe
> (and presumably someone will be debugging), this should be OK.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij
```
