# \[PATCH\] fbmem: remove redundant assignment to err

- Subsystems: FRAMEBUFFER LAYER, FRAMEBUFFER CORE, THE REST
- Maintainers: Helge Deller, Simona Vetter, Linus Torvalds
- Status: LANDED (a74cefd91512 · 2019-07-23 15:14)
- Landed in mainline as a74cefd91512 on 2019-07-23.
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2019/06/5638690/t

## \[PATCH\] fbmem: remove redundant assignment to err

- From: Colin King \<hidden\>
- Date: 2019-06-24 22:37:33 
- Message: https://ratatoskr.run/linux-fbdev/2019/06/5638690.md

```text
From: Colin Ian King <redacted>

Variable err is initialized to a value that is never read and it
is re-assigned later.  The initialization is redundant and can
be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/core/fbmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index dd1a708df1a7..ae044a1325ca 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1987,7 +1987,7 @@ int fb_new_modelist(struct fb_info *info)
 	struct list_head *pos, *n;
 	struct fb_modelist *modelist;
 	struct fb_videomode *m, mode;
-	int err = 1;
+	int err;
 
 	list_for_each_safe(pos, n, &info->modelist) {
 		modelist = list_entry(pos, struct fb_modelist, list);
-- 
2.20.1
```

## Re: \[PATCH\] fbmem: remove redundant assignment to err

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2019-07-23 15:35:13 
- Message: https://ratatoskr.run/linux-fbdev/2019/07/5663254.md

```text

On 6/25/19 12:37 AM, Colin King wrote:
> From: Colin Ian King <redacted>
> 
> Variable err is initialized to a value that is never read and it
> is re-assigned later.  The initialization is redundant and can
> be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <redacted>

Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```